Skip to content

Commit ffb0751

Browse files
authored
Merge branch 'main' into main
2 parents 6553635 + 5e1ccb7 commit ffb0751

File tree

300 files changed

+4122
-543
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

300 files changed

+4122
-543
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions

__tests__/html/transcript.navigation.focusActivity.byClick.onEdges.html

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,14 @@
4545
// THEN: It should focus on the last activity.
4646
expect(pageElements.focusedActivity()).toBe(lastActivity);
4747

48-
// WHEN: Clicking on the pixel above the top left-most pixel of the last activity.
49-
await host.clickAt(lastActivityClientRect.left, lastActivityClientRect.top - 1);
48+
// WHEN: Clicking on the 9 pixels above the top left-most pixel of the last activity.
49+
await host.clickAt(lastActivityClientRect.left, lastActivityClientRect.top - 9);
50+
51+
// THEN: It should still focus on the last activity.
52+
expect(pageElements.focusedActivity()).toBe(lastActivity);
53+
54+
// WHEN: Clicking on the 10 pixels above the top left-most pixel of the last activity.
55+
await host.clickAt(lastActivityClientRect.left, lastActivityClientRect.top - 10);
5056

5157
// THEN: It should focus on the second last activity.
5258
expect(pageElements.focusedActivity()).toBe(secondLastActivity);

__tests__/html/transcript.navigation.focusActivity.scrollIntoView.keyboard.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969

7070
await pageConditions.focusedActivityInView();
7171
expect(pageElements.transcriptScrollable().scrollTop + pageElements.transcriptScrollable().offsetHeight).toBe(
72-
activity29.offsetTop + activity29.offsetHeight
72+
activity29.offsetTop + activity29.offsetHeight + 10 // account for gap between activities
7373
);
7474
await host.snapshot();
7575

@@ -99,7 +99,7 @@
9999
// THEN: It should scroll activity #29 in the view.
100100
await pageConditions.focusedActivityInView();
101101
expect(pageElements.transcriptScrollable().scrollTop).toBe(
102-
[...pageElements.activities()].reverse()[2].offsetTop - 5 // 5px is the margin
102+
[...pageElements.activities()].reverse()[2].offsetTop - 10 // account for gap between activities
103103
);
104104

105105
// THEN: It should show activity #29 completely with top aligned and appropriate spacing.

__tests__/html/transcript.navigation.scrollIntoView.mouse.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@
102102

103103
// THEN: It should scroll activity #2 in the view and align it to the top.
104104
expect(pageElements.transcriptScrollable().scrollTop).toBe(
105-
pageElements.activities()[1].offsetTop - 5 // 5px is the margin
105+
pageElements.activities()[1].offsetTop - 10 // 10px is the gap
106106
);
107107
await host.snapshot();
108108
});
91 Bytes
27 Bytes
0 Bytes
9 Bytes
21 Bytes
-425 Bytes

0 commit comments

Comments
 (0)