Fixed batched livestream activities are not recognized in the same session#5440
Merged
OEvgeny merged 1 commit intomicrosoft:mainfrom Mar 8, 2025
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
beyackle2,
cwhitten,
srinaath and
tdurnford
as code owners
OEvgeny
reviewed
Mar 8, 2025
| (activityIdToKeyMap.get(typingActivityId) || nextActivityIdToKeyMap.get(typingActivityId))) || | ||
| (activityId && (activityIdToKeyMap.get(activityId) || nextActivityIdToKeyMap.get(activityId))) || | ||
| activityToKeyMap.get(activity) || | ||
| nextActivityToKeyMap.get(activity) || |
Collaborator
There was a problem hiding this comment.
As expected next vs previous. Good thing it is now fixed!
OEvgeny
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
On every batch of incoming activities, activity keyer will recreate the keypair map.
Activity keyer will read from the old map and write to the new one. Writing to the new one ensures each render loop is clean of resource leak.
If activities are batched, activity keyer may not found the key as the key could be added in the same round.
This pull request fixed the activity keyer by reading from both new and old map.
Design
If unknown reasons, we cannot reproduce batched activities in the test suite. Or in other words, we do not know why the activities are batched.
We are using Redux store directly to inject activities, before Web Chat is mounted. So, first render will have 2 activities batched.
Specific Changes
ActivityKeyerComposerto read from both new and old mapCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)