Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,13 @@ We prefer using end-to-end visual regression tests (VRT) for pixel-perfect and w

### Running tests manually

Download [ChromeDriver](https://sites.google.com/a/chromium.org/chromedriver/downloads) and extract to the project root.
Download OS-specific version of [ChromeDriver](https://googlechromelabs.github.io/chrome-for-testing/) and extract to the project root.

For MacOS

Give execute permission: `chmod +x ./chromedriver`

Remove quarantine flag: `xattr -d com.apple.quarantine ./chromedriver`

Run `npm run browser`. It will open a new browser window to http://localhost:5001/**tests**/html/. Then, navigate to the test file.

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"precommit:typecheck:core": "cd packages && cd core && npm run precommit:typecheck",
"precommit:typecheck:fluent-theme": "cd packages && cd fluent-theme && npm run precommit:typecheck",
"prepare": "husky",
"start": "NODE_OPTIONS=--no-deprecation concurrently --kill-others --prefix-colors \"auto\" \"npm:start:*\"",
"start": "cross-env NODE_OPTIONS=--no-deprecation concurrently --kill-others --prefix-colors \"auto\" \"npm:start:*\"",
"start:api": "cd packages && cd api && npm start",
"start:bundle": "cd packages && cd bundle && npm start",
"start:component": "cd packages && cd component && npm start",
Expand Down
2 changes: 1 addition & 1 deletion packages/test/harness/src/host/dev/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async function main() {
const hostIP = await findHostIP();
const localIP = await findLocalIP();

const service = await new ChromeServiceBuilder('./chromedriver.exe')
const service = await new ChromeServiceBuilder('./chromedriver')
.addArguments('--allowed-ips', localIP)
.setHostname(hostIP)
.setStdio(['ignore', 'ignore', 'ignore'])
Expand Down
Loading