Ignore ENTER while in text composition mode#5462
Merged
compulim merged 2 commits intomicrosoft:mainfrom Apr 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
ENTER should not send messages if it is in IME text composition mode.
Design
When browser say they are in text composition mode, it means the IME mini-dialog pops up.
While in text composition mode, ENTER key should not be handled by the browser.
On Windows, when IME mini-dialog pops up, all keys are filtered and will not send to the browser.
On macOS, keys are not (completely) filtered.
In the send box of our Fluent skin pack, it use a multiline textbox (
<textarea>) and send on ENTER (new line on SHIFT + ENTER). As macOS did not filter out ENTER, we mistakenly send out the message.We could not write tests as the behavior works outside of browser and emulating
compositionstartevent didn't work.Specific Changes
compositionstartuntilcompositionendI have added tests and executed them locallyCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)