Add attachment bar for preview upload#5464
Merged
compulim merged 64 commits intomicrosoft:mainfrom May 28, 2025
Merged
Conversation
OEvgeny
reviewed
Apr 21, 2025
packages/component/src/SendBox/AttachmentBar/Preview/FileIcon.tsx
Outdated
Show resolved
Hide resolved
OEvgeny
reviewed
May 20, 2025
Collaborator
OEvgeny
left a comment
There was a problem hiding this comment.
Looks good. Need some polish for icons and CSS.
Wasn't the point to add this into both Fluent and white label? Right now I see only white label UX.
Collaborator
There was a problem hiding this comment.
This type of icons is hard to customize, see the above comment re unified icons.
packages/component/src/SendBox/AttachmentBar/Preview/FileIcon.tsx
Outdated
Show resolved
Hide resolved
packages/component/src/SendBox/AttachmentBar/AttachmentBarItem.tsx
Outdated
Show resolved
Hide resolved
packages/component/src/SendBox/AttachmentBar/AttachmentBarItemStyle.ts
Outdated
Show resolved
Hide resolved
packages/component/src/SendBox/AttachmentBar/AttachmentBarItemStyle.ts
Outdated
Show resolved
Hide resolved
packages/component/src/SendBox/AttachmentBar/AttachmentBarItemStyle.ts
Outdated
Show resolved
Hide resolved
OEvgeny
previously approved these changes
May 21, 2025
OEvgeny
previously approved these changes
May 23, 2025
OEvgeny
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
sendAttachmentOn: "send", in PR #5464, by @compulimDescription
Today, upload button will always replace all file attachments. The UX is not great when trying to upload bunches of files from 2+ folders, where 2+ uploads are required, and the second upload overwrite the first upload.
To allow end-user to add files instead of replace, we must allow them to remove attached files. That means, we need attachment preview, where they can choose what files to be removed.
Design
We will add a new "attachment bar" to show attached files:
styleOptions.sendBoxAttachmentBarMaxThumbnailShow as thumbnail
Show as list item
styleOptions.sendBoxAttachmentBarMaxHeightSpecific Changes
<SendBoxAttachmentBar>to<BasicSendBox>CHANGELOG.mdReview Checklist
Browser and platform compatibilities reviewedz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)