Skip to content

Feedback Form should pass when disclaimer isn't present#5469

Merged
compulim merged 8 commits into
microsoft:mainfrom
lexi-taylor:lexi-taylor/feedback-form/disclaimerbug
Apr 26, 2025
Merged

Feedback Form should pass when disclaimer isn't present#5469
compulim merged 8 commits into
microsoft:mainfrom
lexi-taylor:lexi-taylor/feedback-form/disclaimerbug

Conversation

@lexi-taylor

@lexi-taylor lexi-taylor commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Description

Feedback Form had a hard requirement for disclaimer to be present, this was by mistake, the disclaimer should be an optional (not included) property

  • Valibot supports a exactOptional validator but it's in a version webchat doesn't have yet.

  • This allows the disclaimer to operate similarily to exactOptional

  • I have added tests and executed them locally

  • I have updated CHANGELOG.md

  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@lexi-taylor lexi-taylor marked this pull request as ready for review April 25, 2025 17:12

@compulim compulim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update CHANGELOG.md. As this change is small, you can just add the PR number to the existing entry.

Comment thread packages/component/src/Activity/private/hasFeedbackLoop.ts Outdated
Comment thread packages/component/src/Activity/private/hasFeedbackLoop.ts Outdated
Comment thread packages/component/src/Activity/private/hasFeedbackLoop.ts Outdated
Comment thread __tests__/html2/fluentTheme/defaultFeedback.activity.html Outdated
lexi-taylor and others added 5 commits April 25, 2025 17:06
@lexi-taylor lexi-taylor requested a review from compulim April 25, 2025 21:31
@compulim compulim merged commit a6b3ad8 into microsoft:main Apr 26, 2025
@OEvgeny OEvgeny mentioned this pull request Jun 17, 2025
11 tasks
@lexi-taylor lexi-taylor deleted the lexi-taylor/feedback-form/disclaimerbug branch September 15, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants