Skip to content

Feedback Form Bugs: Not rendering markdown and feedback button click not persisting#5470

Merged
OEvgeny merged 56 commits intomicrosoft:mainfrom
lexi-taylor:users/lexi-taylor/feedbackform/bugs
May 5, 2025
Merged

Feedback Form Bugs: Not rendering markdown and feedback button click not persisting#5470
OEvgeny merged 56 commits intomicrosoft:mainfrom
lexi-taylor:users/lexi-taylor/feedbackform/bugs

Conversation

@lexi-taylor
Copy link
Copy Markdown
Contributor

@lexi-taylor lexi-taylor commented Apr 29, 2025

Description

  • When the disclaimer has markdown (bold, italic, links, etc), the feedback form was not rendering the markdown as expected.
  • When a user submits feedback, the feedback button click was not persisting, making it appear like feedback was never submitted by the user

Specific Changes

  1. Added support for markdown in the disclaimer by calling the useRenderMarkdown hook
  2. Ensure feedback button clicks are persisted by not resetting the feedback action state once submit has been pressed. This required introducing a new variable for when feedback has been submitted
  3. Deleted some flaky tests which fail occassionally with the tooltip over the feedback button
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@lexi-taylor lexi-taylor marked this pull request as ready for review April 29, 2025 18:11
OEvgeny
OEvgeny previously approved these changes Apr 29, 2025
Copy link
Copy Markdown
Collaborator

@OEvgeny OEvgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check with links in markdown. You may want to style the links in MCS/Fluent fashion for the Fluent part.

Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussing offline if we should allow C2 to regret their like/dislike, and if we allow regret, what is a proper regret UX.

Recording.2025-04-29.151601.mp4

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@compulim this seems incorrect. I pushed to see if this is the issue.

This reverts commit f0210f8.
@OEvgeny OEvgeny self-requested a review May 3, 2025 05:19
compulim
compulim previously approved these changes May 3, 2025
@compulim
Copy link
Copy Markdown
Contributor

compulim commented May 3, 2025

@OEvgeny are you okay with this PR? I am okay.

OEvgeny
OEvgeny previously approved these changes May 4, 2025
@lexi-taylor lexi-taylor dismissed stale reviews from OEvgeny and compulim via e4a3ac9 May 5, 2025 16:07
Co-authored-by: Eugene <EOlonov@gmail.com>
@OEvgeny OEvgeny enabled auto-merge (squash) May 5, 2025 16:42
@OEvgeny OEvgeny merged commit 5e12798 into microsoft:main May 5, 2025
25 checks passed
@OEvgeny OEvgeny mentioned this pull request Jun 17, 2025
11 tasks
@lexi-taylor lexi-taylor deleted the users/lexi-taylor/feedbackform/bugs branch September 15, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants