Feedback Form Bugs: Not rendering markdown and feedback button click not persisting#5470
Merged
OEvgeny merged 56 commits intomicrosoft:mainfrom May 5, 2025
Merged
Conversation
lexi-taylor
commented
Apr 29, 2025
lexi-taylor
commented
Apr 29, 2025
OEvgeny
previously approved these changes
Apr 29, 2025
Collaborator
OEvgeny
left a comment
There was a problem hiding this comment.
Please check with links in markdown. You may want to style the links in MCS/Fluent fashion for the Fluent part.
compulim
reviewed
Apr 29, 2025
compulim
reviewed
Apr 29, 2025
compulim
reviewed
Apr 29, 2025
Contributor
compulim
left a comment
There was a problem hiding this comment.
Discussing offline if we should allow C2 to regret their like/dislike, and if we allow regret, what is a proper regret UX.
Recording.2025-04-29.151601.mp4
Co-authored-by: William Wong <compulim@users.noreply.github.com>
Co-authored-by: William Wong <compulim@users.noreply.github.com>
OEvgeny
reviewed
Apr 30, 2025
OEvgeny
reviewed
Apr 30, 2025
OEvgeny
reviewed
Apr 30, 2025
OEvgeny
reviewed
Apr 30, 2025
OEvgeny
reviewed
May 3, 2025
OEvgeny
reviewed
May 3, 2025
Collaborator
There was a problem hiding this comment.
@compulim this seems incorrect. I pushed to see if this is the issue.
This reverts commit f0210f8.
compulim
previously approved these changes
May 3, 2025
Contributor
|
@OEvgeny are you okay with this PR? I am okay. |
OEvgeny
previously approved these changes
May 4, 2025
lexi-taylor
commented
May 5, 2025
OEvgeny
reviewed
May 5, 2025
Co-authored-by: Eugene <EOlonov@gmail.com>
OEvgeny
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Specific Changes
useRenderMarkdownhookCHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed