-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Feedback Form Bugs: Not rendering markdown and feedback button click not persisting #5470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OEvgeny
merged 56 commits into
microsoft:main
from
lexi-taylor:users/lexi-taylor/feedbackform/bugs
May 5, 2025
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
d0661ef
initial commit
lexi-taylor e06cf05
revert changes and new snapshots
lexi-taylor b4cfe73
add feedback markdown rendering
lexi-taylor 3c8272c
update changelog
lexi-taylor 89a8721
updating snapshot
lexi-taylor 769f304
fix test
lexi-taylor d954dd3
Update packages/component/src/Activity/private/FeedbackForm.tsx
lexi-taylor c73a833
Update packages/component/src/Activity/private/FeedbackForm.tsx
lexi-taylor 4c581d1
temp changes
lexi-taylor cfde709
fixes
lexi-taylor 9515dee
fix tests
lexi-taylor d02f396
update accidental test changes
lexi-taylor 554c99d
update based on discussion
lexi-taylor 46687f2
update display none
lexi-taylor 9c957f5
update nits
lexi-taylor 8a83108
move tooltip to variable
lexi-taylor d29c1bd
Update packages/component/src/Styles/StyleSet/ThumbButton.ts
lexi-taylor 3518c24
Merge branch 'main' into users/lexi-taylor/feedbackform/bugs
lexi-taylor c39f110
add option to hide feedbackform
lexi-taylor 4a91579
Merge branch 'users/lexi-taylor/feedbackform/bugs' of https://github.…
lexi-taylor c731e43
Revert "add option to hide feedbackform"
lexi-taylor fda2568
use suggestions
lexi-taylor 99f72f5
A few tweaks
OEvgeny 28b488b
Unskip the actions update on changing selected
OEvgeny dc190b8
Preserve initial action
OEvgeny 1e855c4
Resolve selectedAction type before passing to useMemo
OEvgeny e02202f
Unwind the reset/submit logic
OEvgeny 90b5129
change source of truth to feedbackactions
lexi-taylor 11b415e
suggestions
lexi-taylor 90e58a6
remove unnedded newline
lexi-taylor f017f16
refactor feedback loop logic into it's own component
lexi-taylor 7b9dea0
fix failing test
lexi-taylor fc80bc9
Add readonly
compulim 18caeee
Prettier
compulim f6b950f
remove ...entities
lexi-taylor 50420ad
Single source of truth
compulim 157151d
Fix test
compulim 65dd1fc
Improve styles
OEvgeny 05f8bc4
Snaps
OEvgeny e589d02
Fix resubmission logic
compulim 95bef75
Restrict tooltip changes to large button
OEvgeny a97f0d6
More snaps
OEvgeny 3739a35
More snaps
OEvgeny 3fe42d8
More snaps
OEvgeny b769920
More snaps
OEvgeny e93501e
More snaps
OEvgeny d92cf04
Fix test
compulim ce21886
Fix tests
compulim befd73c
Fix test
compulim 8137c19
Fix tests
compulim 372621d
Wait until scroll completed
compulim f0210f8
More snaps
OEvgeny 148cade
Revert "More snaps"
OEvgeny 79085cf
Update like/dislike to have accent color
compulim e4a3ac9
fix width of feedback form
lexi-taylor e71d567
Update packages/component/src/Styles/StyleSet/FeedbackForm.ts
lexi-taylor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+1014 Bytes
(110%)
...__/html/feedback-activity-status-basic-js-vote-button-should-display-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.49 KB
(120%)
...__/html/feedback-activity-status-basic-js-vote-button-should-display-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1017 Bytes
(110%)
...__/html/feedback-activity-status-basic-js-vote-button-should-display-4-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1000 Bytes
(110%)
...back-activity-status-click-js-vote-button-should-send-event-on-click-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.47 KB
(120%)
...back-activity-status-click-js-vote-button-should-send-event-on-click-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.47 KB
(120%)
...back-activity-status-click-js-vote-button-should-send-event-on-click-4-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+40 Bytes
(100%)
...plied-dark-theme-applied-side-by-side-left-transcript-right-feedback-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+38 Bytes
(100%)
...plied-dark-theme-applied-side-by-side-left-transcript-right-feedback-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+31 Bytes
(100%)
...plied-dark-theme-applied-side-by-side-left-transcript-right-feedback-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+34 Bytes
(100%)
...plied-dark-theme-applied-side-by-side-left-transcript-right-feedback-4-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+33 Bytes
(100%)
...plied-dark-theme-applied-side-by-side-left-transcript-right-feedback-5-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+36 Bytes
(100%)
...plied-dark-theme-applied-side-by-side-left-transcript-right-feedback-6-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+35 Bytes
(100%)
...plied-dark-theme-applied-side-by-side-left-transcript-right-feedback-7-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+47 Bytes
(100%)
...-js-fluent-theme-applied-side-by-side-left-transcript-right-feedback-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+750 Bytes
(100%)
...-js-fluent-theme-applied-side-by-side-left-transcript-right-feedback-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+733 Bytes
(100%)
...-js-fluent-theme-applied-side-by-side-left-transcript-right-feedback-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+760 Bytes
(100%)
...-js-fluent-theme-applied-side-by-side-left-transcript-right-feedback-4-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+747 Bytes
(100%)
...-js-fluent-theme-applied-side-by-side-left-transcript-right-feedback-5-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+762 Bytes
(100%)
...-js-fluent-theme-applied-side-by-side-left-transcript-right-feedback-6-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+763 Bytes
(100%)
...-js-fluent-theme-applied-side-by-side-left-transcript-right-feedback-7-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+1.5 KB
(110%)
__tests__/html2/activity/feedback.activity.dismiss.html.snap-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.78 KB
(88%)
__tests__/html2/activity/feedback.activity.dismiss.html.snap-4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+74 Bytes
(100%)
__tests__/html2/activity/feedback.activity.html.snap-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+86 Bytes
(100%)
__tests__/html2/activity/feedback.activity.html.snap-3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+87 Bytes
(100%)
__tests__/html2/activity/feedback.activity.html.snap-4.png
Oops, something went wrong.
Binary file modified
BIN
+85 Bytes
(100%)
__tests__/html2/activity/feedback.activity.html.snap-5.png
Oops, something went wrong.
Diff not rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+14 Bytes
(100%)
__tests__/html2/activity/feedback.form.activity.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-342 Bytes
(98%)
__tests__/html2/activity/feedback.form.activity.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
+8.62 KB
(160%)
__tests__/html2/activity/feedback.form.activity.html.snap-3.png
Oops, something went wrong.
Binary file modified
BIN
-8.73 KB
(60%)
__tests__/html2/activity/feedback.form.activity.html.snap-4.png
Oops, something went wrong.
Diff not rendered.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.