fix: respect outer visibility across Web Chat#5473
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #5472 by ensuring that outer visibility styles are properly inherited in Web Chat. The key changes include replacing 'visibility: visible' with 'visibility: unset' in ThumbButton styles, adding an explanatory comment in the ActivityCopyButton animation keyframe, and updating the changelog.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/component/src/Styles/StyleSet/ThumbButton.ts | Replaced 'visibility: visible' with 'visibility: unset' for proper inheritance |
| packages/component/src/Styles/StyleSet/ActivityCopyButton.ts | Added comment in keyframes to clarify purpose of using 'visibility: visible' during animation |
| CHANGELOG.md | Added a changelog entry for issue #5472 |
Files not reviewed (1)
- packages/fluent-theme/src/components/sendBox/TextArea.module.css: Language not supported
Comments suppressed due to low confidence (2)
packages/component/src/Styles/StyleSet/ThumbButton.ts:58
- Consider verifying that switching to 'unset' fully preserves the desired behavior across all supported browsers, especially for CSS inheritance edge cases.
visibility: 'unset'
packages/component/src/Styles/StyleSet/ThumbButton.ts:69
- Ensure that using 'unset' in this context does not inadvertently remove intended visibility overrides in specific UI states.
visibility: 'unset'
compulim
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
This ensures we mostly don't use
visibility: visibledue to its ability to reveal things if hidden upper in the tree.Design
Use
unsetin place ofvisibleas it resets the value to the initial one, which is properly inherited: https://codepen.io/OEvgeny/pen/qEExOdgSpecific Changes
visibility: visibleoccurrences tovisibility: unset.-
CHANGELOG.mdI have updated documentationReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed