Skip to content

fix: respect outer visibility across Web Chat#5473

Merged
OEvgeny merged 2 commits intomainfrom
fix/visibility
May 1, 2025
Merged

fix: respect outer visibility across Web Chat#5473
OEvgeny merged 2 commits intomainfrom
fix/visibility

Conversation

@OEvgeny
Copy link
Copy Markdown
Collaborator

@OEvgeny OEvgeny commented May 1, 2025

Fixes #5472

Changelog Entry

  • Fixed #5472, ensure proper inheritance from the outside of Web Chat for visibility CSS property when hidden, in PR #5473, by @OEvgeny

Description

This ensures we mostly don't use visibility: visible due to its ability to reveal things if hidden upper in the tree.

Design

Use unset in place of visible as it resets the value to the initial one, which is properly inherited: https://codepen.io/OEvgeny/pen/qEExOdg

Specific Changes

  • Changed visibility: visible occurrences to visibility: unset.

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny requested review from Copilot and removed request for a-b-r-o-w-n, beyackle2, compulim, cwhitten, srinaath and tdurnford May 1, 2025 17:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #5472 by ensuring that outer visibility styles are properly inherited in Web Chat. The key changes include replacing 'visibility: visible' with 'visibility: unset' in ThumbButton styles, adding an explanatory comment in the ActivityCopyButton animation keyframe, and updating the changelog.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
packages/component/src/Styles/StyleSet/ThumbButton.ts Replaced 'visibility: visible' with 'visibility: unset' for proper inheritance
packages/component/src/Styles/StyleSet/ActivityCopyButton.ts Added comment in keyframes to clarify purpose of using 'visibility: visible' during animation
CHANGELOG.md Added a changelog entry for issue #5472
Files not reviewed (1)
  • packages/fluent-theme/src/components/sendBox/TextArea.module.css: Language not supported
Comments suppressed due to low confidence (2)

packages/component/src/Styles/StyleSet/ThumbButton.ts:58

  • Consider verifying that switching to 'unset' fully preserves the desired behavior across all supported browsers, especially for CSS inheritance edge cases.
visibility: 'unset'

packages/component/src/Styles/StyleSet/ThumbButton.ts:69

  • Ensure that using 'unset' in this context does not inadvertently remove intended visibility overrides in specific UI states.
visibility: 'unset'

@OEvgeny OEvgeny merged commit 41e8175 into main May 1, 2025
28 checks passed
@OEvgeny OEvgeny deleted the fix/visibility branch May 1, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thumbs up/down buttons move out of viewport due to visibility property

3 participants