Skip to content

fix: respect outer visibility across Web Chat #5473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OEvgeny merged 2 commits into from
May 1, 2025
Merged

fix: respect outer visibility across Web Chat #5473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7df233
fix: respect outer visibility across Web Chat
OEvgeny May 1, 2025
93e8fab
Changelog
OEvgeny May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ Notes: web developers are advised to use [`~` (tilde range)](https://github.com/
- Fixed [#5439](https://github.com/microsoft/BotFramework-WebChat/issues/5439). Fixed batched livestream activities are not recognized in the same session, in PR [#5440](https://github.com/microsoft/BotFramework-WebChat/pull/5440), by [@compulim](https://github.com/compulim)
- Fixed [#5452](https://github.com/microsoft/BotFramework-WebChat/issues/5452). With Fluent/Copilot theme, the typing indicator padding should not be squashed, in PR [#5453](https://github.com/microsoft/BotFramework-WebChat/pull/5453), by [@compulim](https://github.com/compulim)
- Fixed [#5461](https://github.com/microsoft/BotFramework-WebChat/issues/5461). On macOS and Fluent skinpack applied, using Japanese IME to input some Japanese text should not send them immediately, in PR [#5462](https://github.com/microsoft/BotFramework-WebChat/pull/5462), by [@compulim](https://github.com/compulim)
- Fixed [#5472](https://github.com/microsoft/BotFramework-WebChat/issues/5472), ensure proper inheritance from the outside of Web Chat for visibility CSS property when hidden, in PR [#5473](https://github.com/microsoft/BotFramework-WebChat/pull/5473), by [@OEvgeny](https://github.com/OEvgeny)

# Removed

Expand Down
1 change: 1 addition & 0 deletions packages/component/src/Styles/StyleSet/ActivityCopyButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export default function createActivityButtonStyle() {

'@keyframes webchat__activity-copy-button__copied-animation': {
'0%': {
// This is set during the animation only hence shouldn't spill when hidden from the above tree
visibility: 'visible'
},

Expand Down
4 changes: 2 additions & 2 deletions packages/component/src/Styles/StyleSet/ThumbButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export default function () {
width: 14,

'&.webchat__thumb-button__image--is-stroked': {
visibility: 'visible'
visibility: 'unset'
}
},

Expand All @@ -66,7 +66,7 @@ export default function () {
},

'&.webchat__thumb-button__image--is-filled': {
visibility: 'visible'
visibility: 'unset'
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/fluent-theme/src/components/sendBox/TextArea.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

:global(.webchat-fluent) .sendbox__text-area--in-completion {
.sendbox__text-area-doppelganger {
visibility: visible;
visibility: unset;
}

.sendbox__text-area-input {
Expand Down
Loading