Skip to content

Feedback action placement should only show form for activity-actions#5475

Closed
lexi-taylor wants to merge 4 commits intomicrosoft:mainfrom
lexi-taylor:users/lexi-taylor/fix-activityactions
Closed

Feedback action placement should only show form for activity-actions#5475
lexi-taylor wants to merge 4 commits intomicrosoft:mainfrom
lexi-taylor:users/lexi-taylor/fix-activityactions

Conversation

@lexi-taylor
Copy link
Copy Markdown
Contributor

Description

The feedback form was displaying even if the feedback placement was activity status

Design

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

OEvgeny
OEvgeny previously approved these changes May 7, 2025
@OEvgeny OEvgeny self-requested a review May 15, 2025 19:33
@lexi-taylor lexi-taylor deleted the users/lexi-taylor/fix-activityactions branch September 15, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants