Feedback buttons should not squash other buttons#5480
Merged
compulim merged 31 commits intomicrosoft:mainfrom May 19, 2025
Merged
Feedback buttons should not squash other buttons#5480compulim merged 31 commits intomicrosoft:mainfrom
compulim merged 31 commits intomicrosoft:mainfrom
Conversation
OEvgeny
reviewed
May 17, 2025
OEvgeny
reviewed
May 17, 2025
packages/component/src/ActivityFeedback/providers/private/FocusPropagation.ts
Outdated
Show resolved
Hide resolved
OEvgeny
reviewed
May 17, 2025
packages/component/src/ActivityFeedback/providers/useFeedbackText.ts
Outdated
Show resolved
Hide resolved
OEvgeny
reviewed
May 18, 2025
| import root from './root'; | ||
|
|
||
| // TODO: Test harness and page objects should move to TypeScript. | ||
| // TODO: We should use @testing-library/dom instead. |
Collaborator
There was a problem hiding this comment.
The perf of RTL is what concerns me...
OEvgeny
previously approved these changes
May 18, 2025
OEvgeny
reviewed
May 19, 2025
OEvgeny
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
UI issue
When the feedback form is enabled, the feedback buttons are grouped in a flex container and its width is set to 100%, forcing other component to squash.
Form
A
<form>is now put around the like/dislike button and the feedback form. It will handle all kind of like/dislike and form submissions.Button vs. radio button
<input type="button">and submitted (almost) immediately<input type="radio">Design
Moving from
channelDatatoentitiesToday, due to limitation on Copilot Studio backend, we have to use
channelData.feedbackLoopas a temporary solution to indicate feedback that would have review feedback.{ "channelData": { "feedbackLoop": { "disclaimer": "...", // optional "type": "default" } }, "entities": [ { "@id": "", "@type": "Message" "potentialAction": [ { "@type": "LikeAction" }, { "@type": "DislikeAction" } ] } ], "text": "...", "type": "message" }In this PR, we are leveraging the Schema.org standard:
{ "entities": [ { "@id": "", "@type": "Message" "potentialAction": [ { "@type": "LikeAction", "result": { "@type": "UserReview", "reviewAspect": "..." // optional } }, { "@type": "DislikeAction", "result": { "@type": "UserReview", "reviewAspect": "..." // optional } } ] } ], "text": "...", "type": "message" }The
LikeActionliterally means: "the user liked this message and that action resulted in a user review." The review content (feedback text) will becomeUserReview.reviewBodyin latter PR.We will maintain the backcompat code that migrate
channelData.feedbackLooptoentities[@id=""].potentialAction.resultuntil Copilot Studio fully onboarded the standard payload.Specific Changes
CHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)