Skip to content

Migrate attachments to CSS modules#5491

Merged
OEvgeny merged 4 commits intomainfrom
cssm/attachments
May 31, 2025
Merged

Migrate attachments to CSS modules#5491
OEvgeny merged 4 commits intomainfrom
cssm/attachments

Conversation

@OEvgeny
Copy link
Copy Markdown
Collaborator

@OEvgeny OEvgeny commented May 31, 2025

Fixes #

Changelog Entry

(no changelog entry for the refactor)

Description

This migrates the recently done attachments work over to CSS modules because now we can.

Design

Refactored the icon component into a HOC as well:

  • reusable icons can be added into centralized CSS module
  • configurable via CSS only
  • can later be exposed to be used e.g. in Fluent theme package
  • uses valibot to validate passed props

Specific Changes

  • migrated related components to CSS modules
  • removed previous CSS-in-JS modules
  • cleaned-up the styleSets
  • refactored ComponentIcon
  • added missing theme styles
  • fixed component build missing plugins from the base config

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review May 31, 2025 01:58
compulim
compulim previously approved these changes May 31, 2025
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking.

@OEvgeny OEvgeny merged commit 51b05bb into main May 31, 2025
27 of 28 checks passed
@OEvgeny OEvgeny deleted the cssm/attachments branch May 31, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants