Skip to content

Fluent: add attachments bar#5492

Merged
OEvgeny merged 4 commits intomainfrom
fluent/attachments-bar
Jun 2, 2025
Merged

Fluent: add attachments bar#5492
OEvgeny merged 4 commits intomainfrom
fluent/attachments-bar

Conversation

@OEvgeny
Copy link
Copy Markdown
Collaborator

@OEvgeny OEvgeny commented May 31, 2025

Fixes #

Changelog Entry

  • Resolved #5463. Added attachment preview for sendAttachmentOn: "send", in PR #5464, by @compulim, in PR #5492, by @OEvgeny
    • Attaching files will no longer remove previously attached files
    • Updated Fluent theme to use the new attachment preview feature

Description

This implements the new attachments bar for Fluent skin pack.

Design

The original component is exported and reused in the fluent-theme package. Styles are adjusted to use Fluent design system variables.

Specific Changes

  • Updated Fluent theme attachments implementations
  • Removed unused components from Fluent theme package
  • Updated existing tests: added a test condition for Fluent theme
  • Removed old tests as they're not compatible (2 tests removed in total)
  • Fixed lint error in ComponentIcon component
  • Added a new global handler to render WebChat or WebChat with Fluent skin pack based on theme and variant query parameter

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review May 31, 2025 19:18
compulim
compulim previously approved these changes Jun 2, 2025
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking.

@OEvgeny OEvgeny merged commit ebe5fac into main Jun 2, 2025
28 checks passed
@OEvgeny OEvgeny deleted the fluent/attachments-bar branch June 2, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preview attachment and upload button to append instead of replace

2 participants