Skip to content

Allow feedback form to be submitted without feedback text#5493

Merged
OEvgeny merged 14 commits intomicrosoft:mainfrom
lexi-taylor:users/lexitayor/feedbackform/no-message/bug
Jun 13, 2025
Merged

Allow feedback form to be submitted without feedback text#5493
OEvgeny merged 14 commits intomicrosoft:mainfrom
lexi-taylor:users/lexitayor/feedbackform/no-message/bug

Conversation

@lexi-taylor
Copy link
Copy Markdown
Contributor

@lexi-taylor lexi-taylor commented Jun 3, 2025

Description

Feedback form needs to be submitted in the expected format even when no feedback text is provided (still record like or dislike):
{ "type": "invoke", "name": "message/submitAction", "value": { "actionName": "feedback", "actionValue": { "reaction": "like", "feedback": { "feedbackText": "" } } } }

Design

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

OEvgeny
OEvgeny previously approved these changes Jun 3, 2025
…backComposer.tsx

Co-authored-by: Eugene <EOlonov@gmail.com>
@lexi-taylor lexi-taylor requested a review from OEvgeny June 4, 2025 12:22
OEvgeny
OEvgeny previously approved these changes Jun 5, 2025
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes:

  • Replaced the deprecated hasFeedbackLoop with isRequireReviewAction
    • The hasFeedbackLoop is designed for patching service and it should not be called outside of patching, thus, it is marked as deprecated
  • Moved the test from /fluent/ to /feedbackForm/
    • /fluent/ is for things that is specific to Fluent, such as layout or specialized behaviors. This "empty feedback" feature is not specific to Fluent
  • Fixed a test which part of the steps were skipped
  • Added deprecation notes to helper functions marked as deprecated, they are for patching the service

@compulim
Copy link
Copy Markdown
Contributor

@OEvgeny can you review my changes? If you are okay, please approve and merge it. 🙂

@OEvgeny OEvgeny merged commit 5981589 into microsoft:main Jun 13, 2025
25 checks passed
@OEvgeny OEvgeny mentioned this pull request Jun 17, 2025
11 tasks
@lexi-taylor lexi-taylor deleted the users/lexitayor/feedbackform/no-message/bug branch September 15, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants