Skip to content

chore: remove fluent bundle and use esm.sh instead#5497

Merged
OEvgeny merged 2 commits intomainfrom
chore/remove-fluent-bundle
Jun 13, 2025
Merged

chore: remove fluent bundle and use esm.sh instead#5497
OEvgeny merged 2 commits intomainfrom
chore/remove-fluent-bundle

Conversation

@OEvgeny
Copy link
Copy Markdown
Collaborator

@OEvgeny OEvgeny commented Jun 12, 2025

Fixes #

Changelog Entry

(no changelog entry for internal change)

Description

This removes the fluent-bundle package we used for testing integration with FluentUI theme. Now we use esm.sh CDN instead to retrieve components needed for testing. This also upgrades a portion of tests using the fluent components to new html runner.

Specific Changes

  • migrated affected tests to html runner and updated them to use esm.sh instead of locally built fluent-bundle package
  • removed fluent-bundle package
  • added more tests for dark fluent theme

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review June 12, 2025 23:25
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a (default) bot icon to copilot theme later? So the "Lorem Ipsum Expert" don't looks too off.

Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer need the fluent-bundle. But the best part to me is... moving things to /html2/. 🤣

I want to try GitHub Copilot agent to do it... because at some point of time, I saw Git said I did a file rename but I definitely modified the file content as well. I don't have a lot of confidence trusting Git says rename vs. modification... yet.

@OEvgeny OEvgeny merged commit d66bb72 into main Jun 13, 2025
28 checks passed
@OEvgeny OEvgeny deleted the chore/remove-fluent-bundle branch June 13, 2025 17:02
@OEvgeny
Copy link
Copy Markdown
Collaborator Author

OEvgeny commented Jun 13, 2025

This PR was partially made with Copilot. Let me get this experiment going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants