chore: remove fluent bundle and use esm.sh instead#5497
Merged
Conversation
compulim
reviewed
Jun 13, 2025
compulim
reviewed
Jun 13, 2025
compulim
reviewed
Jun 13, 2025
Contributor
There was a problem hiding this comment.
Should we add a (default) bot icon to copilot theme later? So the "Lorem Ipsum Expert" don't looks too off.
compulim
reviewed
Jun 13, 2025
packages/fluent-theme/src/components/activity/ActivityDecorator.module.css
Show resolved
Hide resolved
compulim
approved these changes
Jun 13, 2025
Contributor
There was a problem hiding this comment.
We no longer need the fluent-bundle. But the best part to me is... moving things to /html2/. 🤣
I want to try GitHub Copilot agent to do it... because at some point of time, I saw Git said I did a file rename but I definitely modified the file content as well. I don't have a lot of confidence trusting Git says rename vs. modification... yet.
Collaborator
Author
|
This PR was partially made with Copilot. Let me get this experiment going. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
(no changelog entry for internal change)
Description
This removes the
fluent-bundlepackage we used for testing integration with FluentUI theme. Now we use esm.sh CDN instead to retrieve components needed for testing. This also upgrades a portion of tests using the fluent components to new html runner.Specific Changes
fluent-bundlepackagefluent-bundlepackage-
I have updatedCHANGELOG.mdI have updated documentationReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed