rpc to handle post message: focus#5500
Closed
marclundgren wants to merge 5 commits intomicrosoft:mainfrom
Closed
Conversation
Collaborator
|
It'd be great to have tests as well. Also need @compulim to weigh on design. |
Contributor
Author
Good idea. I added a new test file |
d599435 to
fa286d4
Compare
Contributor
Author
|
closing in favor of #5512 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds cross-iframe RPC (Remote Procedure Call) functionality to enable parent applications to programmatically focus WebChat elements when
WebChat is embedded in an iframe. This addresses the common use case where WebChat runs inside an iframe and the parent application needs to control
focus behavior but cannot directly access DOM elements due to security restrictions.
The implementation provides a secure postMessage-based communication system that allows external applications to trigger WebChat's existing focus
management system across iframe boundaries.
Design
The solution follows WebChat's existing architectural patterns:
useFocus()hook internally for proper focus managementThe design uses WebChat's established patterns:
useFocus()hookSpecific Changes
Added
PostMessageListener.tsx: New component that handles cross-iframe focus commandsWEBCHAT_FOCUSmessage type'sendBox','sendBoxWithoutKeyboard','main'Updated
Composer.tsx: Integrated PostMessageListener into the main component treeAdded comprehensive sample:
samples/04.api/o.iframe-rpc-focus/Updated samples documentation: Added new sample to
samples/README.mdAPI Usage
Included Demo
Testing
Review Checklist
This section is for contributors to review your work.
The key points covered: