Skip to content

Refactor text area and feedback loop#5501

Merged
OEvgeny merged 2 commits intomainfrom
chore/refactor-text-area
Jun 17, 2025
Merged

Refactor text area and feedback loop#5501
OEvgeny merged 2 commits intomainfrom
chore/refactor-text-area

Conversation

@OEvgeny
Copy link
Copy Markdown
Collaborator

@OEvgeny OEvgeny commented Jun 17, 2025

Fixes #

Changelog Entry

Description

The PR contains a refactor of the feedback loop code with the CSS modules approach and a shared text area component implementation. The new text area implementation is also reused inside the Fluent Theme.

Specific Changes

  • The TextArea component was moved from the fluent-theme package to component package
  • The component was reused in both packages
  • The component styles and related FeedbackForm styles were migrated to CSS-modules
  • Added tests for scroll
  • Fixed minor issues with the colors and scroll

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review June 17, 2025 21:54
@OEvgeny OEvgeny merged commit 44688ae into main Jun 17, 2025
28 checks passed
@OEvgeny OEvgeny deleted the chore/refactor-text-area branch June 17, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants