Skip to content

feat: new icons subsystem#5502

Merged
OEvgeny merged 12 commits intomainfrom
feat/rework-icons
Jun 23, 2025
Merged

feat: new icons subsystem#5502
OEvgeny merged 12 commits intomainfrom
feat/rework-icons

Conversation

@OEvgeny
Copy link
Copy Markdown
Collaborator

@OEvgeny OEvgeny commented Jun 18, 2025

Fixes #

Changelog Entry

  • Enabled icon customization in Fluent theme through CSS variables, in PR #5413, by @OEvgeny

Description

This continues the work on modernizing how Web Chat handles icons via a dedicated icon component and CSS-modules. Now almost all icons are defined in CSS which makes DOM lighter and easier to customize.

Design

As Fluent design system is independent from Web Chat, we have two different components handling both icon sets bootstrapped by the createIconComponent utility.

The utility handles the heavy lifting of passed props validation at runtime.

Specific Changes

  • migrated most of the icon to ComponentIcon approach
  • minor tests updates
  • updated attachment icon to address a TODO item
  • simplified modal close button layout
  • fixed minor styling issues with Fluent icons color
  • updated snapshots

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review June 19, 2025 00:49
@OEvgeny OEvgeny requested a review from compulim June 21, 2025 00:07
@OEvgeny OEvgeny merged commit eab9284 into main Jun 23, 2025
28 checks passed
@OEvgeny OEvgeny deleted the feat/rework-icons branch June 23, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants