-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: new icons subsystem #5502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8a4fcc2
feat: new icons subsystem
OEvgeny 749078c
Fix more snaps
OEvgeny 5cae786
Changelog
OEvgeny 7470d2c
Migrate feedback buttons
OEvgeny 4918ce1
Update download icon
OEvgeny f0c5587
Add Web Chat test and more icons customization
OEvgeny bb03598
fix mask url should be encoded
OEvgeny 1ff54e6
Use stringify instead of encodeURI/decodeURI for mask URLs
OEvgeny 832efdd
Infer modifiers in ts
OEvgeny a4686b8
Expose modifier props checking
OEvgeny 9925e06
Fix FluentIcon createIconComponent usage
OEvgeny 67855c4
Fix typecheck
OEvgeny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-46 Bytes
(100%)
...gion-should-render-send-failed-retry-correctly-in-high-contrast-mode-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-41 Bytes
(100%)
...gh-contrast-mode-hero-card-with-buttons-pushed-should-be-highlighted-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-22 Bytes
(100%)
...t-on-of-send-should-send-attachments-when-the-send-button-is-clicked-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-22 Bytes
(100%)
...ent-on-unset-should-send-attachments-when-the-send-button-is-clicked-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-22 Bytes
(100%)
...for-the-flow-should-send-attachments-when-the-send-button-is-clicked-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-35 Bytes
(100%)
...for-the-flow-should-send-attachments-when-the-send-button-is-clicked-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-18 Bytes
(100%)
...-use-send-box-attachments-hook-should-get-set-and-upload-attachments-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <!doctype html> | ||
| <html> | ||
| <head> | ||
| <title>Renders custom icons (fluent)</title> | ||
| <script> | ||
| location = './customIcons?theme=fluent'; | ||
| </script> | ||
| </head> | ||
| <body></body> | ||
| </html> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| <!doctype html> | ||
| <html lang="en-US"> | ||
| <head> | ||
| <title>Render custom icons replaced via CSS</title> | ||
| <link href="/assets/index.css" rel="stylesheet" type="text/css" /> | ||
| <script type="importmap"> | ||
| { | ||
| "imports": { | ||
| "react": "https://esm.sh/react@18.3.1", | ||
| "react-dom": "https://esm.sh/react-dom@18.3.1", | ||
| "react-dom/": "https://esm.sh/react-dom@18.3.1/", | ||
| "@fluentui/react-components": "https://esm.sh/@fluentui/react-components?deps=react@18.3.1&exports=FluentProvider,createDarkTheme,webLightTheme" | ||
| } | ||
| } | ||
| </script> | ||
| <script crossorigin="anonymous" src="/test-harness.js"></script> | ||
| <script crossorigin="anonymous" src="/test-page-object.js"></script> | ||
| <script type="module"> | ||
| import React from 'react'; | ||
| import ReactDOM from 'react-dom'; | ||
|
|
||
| window.React = React; | ||
| window.ReactDOM = ReactDOM; | ||
| </script> | ||
| <script defer crossorigin="anonymous" src="/__dist__/webchat-es5.js"></script> | ||
| <script defer crossorigin="anonymous" src="/__dist__/botframework-webchat-fluent-theme.production.min.js"></script> | ||
| <style> | ||
| #webchat .webchat__send-box__main .component-icon.icon--send, | ||
| #webchat .sendbox__toolbar-button .fluent-icon.icon--send { | ||
| --icon: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='2 2 22 22'%3E%3Cpath fill='%23000' d='M4 18.5v-13L19.423 12zM5 17l11.85-5L5 7v3.885L9.846 12L5 13.116zm0 0V7z'/%3E%3C/svg%3E"); | ||
| --webchat__component-icon--mask: var(--icon); | ||
| --webchat__fluent-icon--mask: var(--icon); | ||
| } | ||
|
|
||
| #webchat .webchat__send-box__main .component-icon.icon--attachment, | ||
| #webchat .sendbox__toolbar-button .fluent-icon.icon--attachment { | ||
| --icon: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='2 2 22 22'%3E%3Cpath fill='%23000' d='M16.346 11.385V6.769h1v4.616zm-5.538 5.457q-.452-.269-.726-.734q-.274-.466-.274-1.031V6.769h1zM11.96 21q-2.271 0-3.846-1.595t-1.575-3.867v-8.73q0-1.587 1.09-2.697Q8.722 3 10.309 3t2.678 1.11t1.091 2.698V14h-1V6.789q-.006-1.166-.802-1.977T10.308 4q-1.163 0-1.966.821q-.804.821-.804 1.987v8.73q-.005 1.853 1.283 3.157Q10.11 20 11.961 20q.556 0 1.056-.124t.945-.372v1.11q-.468.2-.972.293q-.505.093-1.03.093m4.386-1v-2.616h-2.615v-1h2.615V13.77h1v2.615h2.616v1h-2.616V20z'/%3E%3C/svg%3E"); | ||
| --webchat__component-icon--mask: var(--icon); | ||
| --webchat__fluent-icon--mask: var(--icon); | ||
| } | ||
|
|
||
| #webchat .webchat__activity-button .component-icon.icon--view-code { | ||
| --webchat__component-icon--mask: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'%3E%3Cpath fill='%23000' d='M8 17.308L2.692 12L8 6.692l.714.714l-4.6 4.6L8.708 16.6zm8 0l-.713-.714l4.6-4.6L15.292 7.4L16 6.692L21.308 12z'/%3E%3C/svg%3E"); | ||
| } | ||
|
|
||
| #webchat .webchat__activity-button .component-icon.icon--copy { | ||
| --webchat__component-icon--mask: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'%3E%3Cpath fill='%23000' d='M9.116 17q-.691 0-1.153-.462T7.5 15.385V4.615q0-.69.463-1.153T9.116 3h7.769q.69 0 1.153.462t.462 1.153v10.77q0 .69-.462 1.152T16.884 17zm0-1h7.769q.23 0 .423-.192t.192-.423V4.615q0-.23-.192-.423T16.884 4H9.116q-.231 0-.424.192t-.192.423v10.77q0 .23.192.423t.423.192m-3 4q-.69 0-1.153-.462T4.5 18.385V6.615h1v11.77q0 .23.192.423t.423.192h8.77v1zM8.5 16V4z'/%3E%3C/svg%3E"); | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <main id="webchat"></main> | ||
| <script type="module"> | ||
| run(async function () { | ||
| const { directLine, store } = testHelpers.createDirectLineEmulator(); | ||
|
|
||
| renderWebChat({ directLine, store }, document.getElementById('webchat')); | ||
|
|
||
| await pageConditions.uiConnected(); | ||
|
|
||
| const aiMessageEntity = { | ||
| '@context': 'https://schema.org', | ||
| '@id': '', | ||
| '@type': 'Message', | ||
| keywords: ['AIGeneratedContent', 'AllowCopy'], | ||
| type: 'https://schema.org/Message' | ||
| }; | ||
|
|
||
| directLine.emulateIncomingActivity({ | ||
| from: { role: 'bot' }, | ||
| entities: [{ | ||
| ...aiMessageEntity, | ||
| isBasedOn: { | ||
| '@type': 'SoftwareSourceCode', | ||
| 'programmingLanguage': 'python', | ||
| "text": `print("Hello, World!")` | ||
| } | ||
| }], | ||
| type: "message", | ||
| text: `This example demonstrates custom icons in Web Chat`, | ||
| }); | ||
|
|
||
| await pageConditions.numActivitiesShown(1); | ||
|
|
||
| // THEN: Should render the icon. | ||
| await host.snapshot('local'); | ||
| }); | ||
| </script> | ||
| </body> | ||
| </html> | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
__tests__/html2/copyButton/layout.copilot.dark.html.snap-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-13 Bytes
(100%)
__tests__/html2/copyButton/layout.fluent.dark.html.snap-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-109 Bytes
(100%)
__tests__/html2/feedbackForm/feedback.status.html.snap-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-115 Bytes
(100%)
__tests__/html2/feedbackForm/feedback.status.html.snap-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-128 Bytes
(100%)
__tests__/html2/feedbackForm/feedback.status.html.snap-3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-118 Bytes
(100%)
__tests__/html2/feedbackForm/feedback.status.html.snap-4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-79 Bytes
(100%)
__tests__/html2/feedbackForm/feedback.status.html.snap-5.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-69 Bytes
(99%)
__tests__/html2/feedbackStatus/feedbackActivityStatus.basic.html.snap-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-82 Bytes
(99%)
__tests__/html2/feedbackStatus/feedbackActivityStatus.basic.html.snap-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-96 Bytes
(99%)
__tests__/html2/feedbackStatus/feedbackActivityStatus.basic.html.snap-3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-81 Bytes
(99%)
__tests__/html2/feedbackStatus/feedbackActivityStatus.basic.html.snap-4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-69 Bytes
(99%)
__tests__/html2/feedbackStatus/feedbackActivityStatus.click.html.snap-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-35 Bytes
(100%)
__tests__/html2/feedbackStatus/feedbackActivityStatus.click.html.snap-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-44 Bytes
(100%)
__tests__/html2/feedbackStatus/feedbackActivityStatus.click.html.snap-3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-44 Bytes
(100%)
__tests__/html2/feedbackStatus/feedbackActivityStatus.click.html.snap-4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-38 Bytes
(100%)
__tests__/html2/feedbackStatus/feedbackActivityStatus.single.html.snap-1.png
Oops, something went wrong.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Diff not rendered.
Binary file modified
BIN
-109 Bytes
(100%)
__tests__/html2/preact/activity/feedback.status.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-115 Bytes
(100%)
__tests__/html2/preact/activity/feedback.status.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
-127 Bytes
(100%)
__tests__/html2/preact/activity/feedback.status.html.snap-3.png
Oops, something went wrong.
Binary file modified
BIN
-118 Bytes
(100%)
__tests__/html2/preact/activity/feedback.status.html.snap-4.png
Oops, something went wrong.
Binary file modified
BIN
-79 Bytes
(100%)
__tests__/html2/preact/activity/feedback.status.html.snap-5.png
Oops, something went wrong.
Binary file modified
BIN
-29 Bytes
(100%)
__tests__/html2/sendBox/previewBeforeSend/clearAfterSend.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-28 Bytes
(100%)
__tests__/html2/sendBox/previewBeforeSend/deleteButtonInTextMode.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-16 Bytes
(100%)
__tests__/html2/sendBox/previewBeforeSend/escapeKey.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-29 Bytes
(100%)
__tests__/html2/sendBox/previewBeforeSend/escapeKey.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
-34 Bytes
(100%)
__tests__/html2/sendBox/previewBeforeSend/filePreview.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-114 Bytes
(99%)
__tests__/html2/sendBox/previewBeforeSend/styleOptions.maxHeight.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-140 Bytes
(99%)
__tests__/html2/sendBox/previewBeforeSend/styleOptions.maxHeight.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
-90 Bytes
(99%)
__tests__/html2/sendBox/previewBeforeSend/styleOptions.two.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-61 Bytes
(99%)
__tests__/html2/sendBox/previewBeforeSend/styleOptions.zero.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-91 Bytes
(99%)
__tests__/html2/sendBox/previewBeforeSend/textOnly.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-115 Bytes
(99%)
__tests__/html2/sendBox/previewBeforeSend/textOnlyMaxHeight.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-27 Bytes
(100%)
__tests__/html2/sendBox/previewBeforeSend/threeImages.dark.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-39 Bytes
(100%)
__tests__/html2/sendBox/previewBeforeSend/threeImages.dark.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
-27 Bytes
(100%)
__tests__/html2/sendBox/previewBeforeSend/threeImages.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-39 Bytes
(100%)
__tests__/html2/sendBox/previewBeforeSend/threeImages.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
-35 Bytes
(100%)
__tests__/html2/sendBox/sendAttachmentOn/withMessage.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-43 Bytes
(100%)
__tests__/html2/sendBox/sendAttachmentOn/withMessage.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
+2 Bytes
(100%)
__tests__/html2/side-by-side/codeblock-dark.navigation.dark.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
+7 Bytes
(100%)
__tests__/html2/side-by-side/codeblock-dark.navigation.dark.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
+0 Bytes
(100%)
__tests__/html2/side-by-side/codeblock-dark.navigation.dark.html.snap-3.png
Oops, something went wrong.
Binary file modified
BIN
+1 Byte
(100%)
__tests__/html2/side-by-side/codeblock-dark.navigation.dark.html.snap-5.png
Oops, something went wrong.
Binary file modified
BIN
-15 Bytes
(100%)
__tests__/html2/side-by-side/codeblock-dark.navigation.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-18 Bytes
(100%)
__tests__/html2/side-by-side/codeblock-dark.navigation.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
-37 Bytes
(100%)
__tests__/html2/side-by-side/codeblock-dark.navigation.html.snap-3.png
Oops, something went wrong.
Binary file modified
BIN
-40 Bytes
(100%)
__tests__/html2/side-by-side/codeblock-dark.navigation.html.snap-5.png
Oops, something went wrong.
Binary file modified
BIN
+5 Bytes
(100%)
__tests__/html2/side-by-side/codeblock.navigation.dark.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
+1 Byte
(100%)
__tests__/html2/side-by-side/codeblock.navigation.dark.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
+6 Bytes
(100%)
__tests__/html2/side-by-side/codeblock.navigation.dark.html.snap-3.png
Oops, something went wrong.
Binary file modified
BIN
+5 Bytes
(100%)
__tests__/html2/side-by-side/codeblock.navigation.dark.html.snap-5.png
Oops, something went wrong.
Binary file modified
BIN
-14 Bytes
(100%)
__tests__/html2/side-by-side/codeblock.navigation.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-23 Bytes
(100%)
__tests__/html2/side-by-side/codeblock.navigation.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
-41 Bytes
(100%)
__tests__/html2/side-by-side/codeblock.navigation.html.snap-3.png
Oops, something went wrong.
Binary file modified
BIN
-33 Bytes
(100%)
__tests__/html2/side-by-side/codeblock.navigation.html.snap-5.png
Oops, something went wrong.
Binary file modified
BIN
-13 Bytes
(100%)
__tests__/html2/side-by-side/feedback.navigation.dark.html.snap-1.png
Oops, something went wrong.
Binary file modified
BIN
-10 Bytes
(100%)
__tests__/html2/side-by-side/feedback.navigation.dark.html.snap-2.png
Oops, something went wrong.
Binary file modified
BIN
-10 Bytes
(100%)
__tests__/html2/side-by-side/feedback.navigation.dark.html.snap-3.png
Oops, something went wrong.
Binary file modified
BIN
-17 Bytes
(100%)
__tests__/html2/side-by-side/feedback.navigation.dark.html.snap-4.png
Oops, something went wrong.
Binary file modified
BIN
-20 Bytes
(100%)
__tests__/html2/side-by-side/feedback.navigation.dark.html.snap-5.png
Oops, something went wrong.
Binary file modified
BIN
-2 Bytes
(100%)
__tests__/html2/side-by-side/feedback.navigation.dark.html.snap-6.png
Oops, something went wrong.
Binary file modified
BIN
-11 Bytes
(100%)
__tests__/html2/side-by-side/feedback.navigation.dark.html.snap-7.png
Oops, something went wrong.
Binary file modified
BIN
+46 Bytes
(100%)
__tests__/html2/side-by-side/transcript.navigation.dark.html.snap-17.png
Oops, something went wrong.
Binary file modified
BIN
+6 Bytes
(100%)
__tests__/html2/side-by-side/transcript.navigation.dark.html.snap-9.png
Oops, something went wrong.
Binary file modified
BIN
+22 Bytes
(100%)
__tests__/html2/side-by-side/transcript.navigation.fluent.dark.html.snap-9.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 0 additions & 36 deletions
36
packages/component/src/ActivityFeedback/private/ThumbDislike16Filled.tsx
This file was deleted.
Oops, something went wrong.
37 changes: 0 additions & 37 deletions
37
packages/component/src/ActivityFeedback/private/ThumbDislike16Regular.tsx
This file was deleted.
Oops, something went wrong.
36 changes: 0 additions & 36 deletions
36
packages/component/src/ActivityFeedback/private/ThumbLike16Filled.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.