Add support for streaming through entities#5517
Merged
compulim merged 57 commits intomicrosoft:mainfrom Aug 22, 2025
Merged
Conversation
…pport Merge pull request #1 from kylerohnmsft/main
…this is pretty rough)
Member
Tests are fully passing now. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for reading livestreaming metadata from the entities field in addition to the existing channelData field support. Microsoft platforms are migrating to use the entities field for streaming information, requiring WebChat to support both locations with entities taking priority.
Key changes:
- Enhanced schema validation to check both
entitiesandchannelDatafor streaming metadata - Added abstraction layer for streaming data schemas to improve maintainability
- Comprehensive test coverage for entities-based streaming scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/core/src/utils/getActivityLivestreamingMetadata.ts |
Core logic updated to parse streaming data from entities field with fallback to channelData |
packages/core/src/utils/getActivityLivestreamingMetadata.spec.ts |
Added comprehensive test cases for entities-based streaming scenarios |
docs/LIVESTREAMING.md |
Added documentation example showing entities field usage |
CHANGELOG.md |
Added changelog entry for the new feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
Seems validation is too strict / not right @compulim |
OEvgeny
approved these changes
Aug 22, 2025
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changelog Entry
entitiesin PR #5517 by @kylerohnnote: actual changes made by kylerohnmsft, but linking personal account to show contribution after internship ends
Description
Microsoft platforms such as the Agents SDKs are now putting streaming information in the
entitiesfield rather than thechannelDatafield. This means that BotFramework-WebChat must be able to handle reading streaming data from either location, prioritizing reading from entities.Design
Nothing fundamental about the code flow was changed. getActivityLivestreamingMetadata() was edited such that entities is checked for streaming data before channelData. If the streaming data is found in entities, it uses that data to encode the livestreaming metadata. Otherwise, it moves on to channelData and the code executes as it did before. Changes were made to abstract some of the Schema structure such that overall code maintenance should be easier moving forward.
Specific Changes
entitiesfield of activity for streaming dataentities-
CHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed