Conversation
compulim
changed the title
fetch from requestfetch from request
compulim
changed the title
fetch from request
compulim
changed the title
compulim
requested review from
a-b-r-o-w-n,
beyackle2,
cwhitten,
srinaath and
tdurnford
as code owners
OEvgeny
approved these changes
Aug 2, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated dependencies from the BotFramework WebChat codebase, modernizing the packages by replacing deprecated libraries with native browser APIs and updated tooling.
- Replaced deprecated
requestandrequest-progresspackages with nativefetchAPI in cldr-data-downloader - Removed
abort-controller-es5ponyfill from directlinespeech package since AbortController is now natively supported in modern browsers - Added missing
esbuilddependency to botframework-webchat-styles package
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/support/cldr-data-downloader/src/download.js | Replaced request/request-progress with fetch API and implemented manual progress tracking |
| packages/support/cldr-data-downloader/package.json | Removed deprecated request and request-progress dependencies |
| packages/styles/package.json | Added missing esbuild dependency |
| packages/directlinespeech/src/createWebSpeechPonyfillFactory.js | Removed import of abort-controller-es5 ponyfill |
| packages/directlinespeech/package.json | Removed abort-controller-es5 dependency |
| tests/html/sendAttachmentOn/*.html | Reordered test conditions for better test reliability |
| CHANGELOG.md | Updated with breaking changes and dependency removal notes |
Collaborator
|
This closes #5483 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Breaking changes
botframework-directlinespeech-sdkno longer ponyfillAbortController, it is supported by modern browsers, in PR #5530Changed
abort-controller-es5package inbotframework-directlinespeech-sdkpackage, in PR #5530, by @compulimrequestandrequest-progresspackage incldr-data-downloaderpackage, in PR #5530, by @copilot and @compulimDescription
This is further clean up after PR #5529 of bump dependencies.
We cannot update
serveyet asserve@14.2.4(latest) is still depending oncompression@1.7.4, which depends on vulnerable version ofon-headers, tracking at vercel/serve#824.Design
Specific Changes
cldr-data-downloader: Removedrequestandrequest-progressas they are deprecated since 2020directlinespeech-sdk: Removedabort-controller-es5asAbortControlleris supported by most browsersbotframework-webchat-styles: Added missingesbuilddependencyI have added tests and executed them locallyCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)