Merged
Conversation
OEvgeny
reviewed
Aug 7, 2025
OEvgeny
approved these changes
Aug 7, 2025
Collaborator
OEvgeny
left a comment
There was a problem hiding this comment.
Love platform neutrality ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
@msinternal/botframework-webchat-tsconfigto centralize TypeScript configuration files, in PR #5539, by @compulimDescription
Added new
@msinternal/botframework-webchat-tsconfigfor centralizing TypeScript configuration files and pave way for convergence.Design
Naming
Instead of naming the current config as "strictest", prefer "current" because the configuration is not "purely strict", it's "strict plus some Web Chat-specific configurations."
Setting
typesto empty arrayBy default, TypeScript will load all
node_modules/@types/*. It would allowbefore/test/afterin production code.We are setting
types: []to explicitly setting the types to empty. The package would need to set their types library accordingly. For example,coreis empty, whilecomponentisdom-speech-recognition.However, we would add types using triple reference to test files.
Specific Changes
@msinternal/botframework-webchat-tsconfigpackagetsconfig.jsonto the new packagefeatures/cssModulesconfiguration file<reference types="jest" />to test files<reference types="node" />to CommonJS filesI have added tests and executed them locallyCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)