Skip to content

Centralize tsconfig.json#5539

Merged
compulim merged 20 commits intomainfrom
feat-tsconfig
Aug 8, 2025
Merged

Centralize tsconfig.json#5539
compulim merged 20 commits intomainfrom
feat-tsconfig

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Aug 7, 2025

Changelog Entry

Changed

  • Added internal package @msinternal/botframework-webchat-tsconfig to centralize TypeScript configuration files, in PR #5539, by @compulim

Description

Added new @msinternal/botframework-webchat-tsconfig for centralizing TypeScript configuration files and pave way for convergence.

Design

Naming

Instead of naming the current config as "strictest", prefer "current" because the configuration is not "purely strict", it's "strict plus some Web Chat-specific configurations."

Setting types to empty array

By default, TypeScript will load all node_modules/@types/*. It would allow before/test/after in production code.

We are setting types: [] to explicitly setting the types to empty. The package would need to set their types library accordingly. For example, core is empty, while component is dom-speech-recognition.

However, we would add types using triple reference to test files.

Specific Changes

  • Added new @msinternal/botframework-webchat-tsconfig package
  • Unified all production-related tsconfig.json to the new package
  • Added new features/cssModules configuration file
  • Added <reference types="jest" /> to test files
  • Added <reference types="node" /> to CommonJS files
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review August 7, 2025 05:09
Copy link
Copy Markdown
Collaborator

@OEvgeny OEvgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love platform neutrality ❤️

@compulim compulim merged commit 6c94bd4 into main Aug 8, 2025
28 checks passed
@compulim compulim deleted the feat-tsconfig branch August 8, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants