Skip to content

Migrate __tests__/html/accessibility* to html2#5541

Merged
compulim merged 5 commits intomainfrom
feat-upgrade-test-1
Aug 8, 2025
Merged

Migrate __tests__/html/accessibility* to html2#5541
compulim merged 5 commits intomainfrom
feat-upgrade-test-1

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Aug 7, 2025

Fixes #

Changelog Entry

Description

(Slowly) upgrading all html tests to html2 tests.

Design

Specific Changes

  • Upgraded html/accessibility*
  • Fixed accessibility.attachment.carouselLayoutRole test, it was not running previously
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review August 7, 2025 21:38
OEvgeny
OEvgeny previously approved these changes Aug 8, 2025
Copy link
Copy Markdown
Collaborator

@OEvgeny OEvgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a couple of snapshots to be added

@compulim compulim force-pushed the feat-upgrade-test-1 branch from 4a22b83 to bd30322 Compare August 8, 2025 06:18
@compulim compulim changed the title Migrate __tests__/html/accessibility* to html2 [WIP] Migrate __tests__/html/accessibility* to html2 Aug 8, 2025
@compulim compulim marked this pull request as draft August 8, 2025 06:19
@compulim compulim changed the title [WIP] Migrate __tests__/html/accessibility* to html2 Migrate __tests__/html/accessibility* to html2 Aug 8, 2025
@compulim compulim marked this pull request as ready for review August 8, 2025 07:30
@compulim
Copy link
Copy Markdown
Contributor Author

compulim commented Aug 8, 2025

Verified it's purely rename and removing barrel HTML files.

@compulim compulim merged commit 5125770 into main Aug 8, 2025
28 checks passed
@compulim compulim deleted the feat-upgrade-test-1 branch August 8, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants