Complete deprecation of activityMiddleware.nextVisibleActivity and activityMiddleware.sameTimestampGroup#5565
Merged
compulim merged 3 commits intomicrosoft:mainfrom Sep 2, 2025
Conversation
compulim
requested review from
a-b-r-o-w-n,
beyackle2,
cwhitten,
srinaath and
tdurnford
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated nextVisibleActivity and sameTimestampGroup properties from the activity status middleware as part of a planned cleanup. The deprecation was originally scheduled for removal on or after 2022-07-22.
- Removes all references to the deprecated
nextVisibleActivityandsameTimestampGroupproperties - Updates samples and test files to use the new
hideTimestampproperty instead - Simplifies function signatures and middleware by eliminating the deprecated parameters
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/api/src/types/ActivityStatusMiddleware.ts | Removes deprecated properties from the type definition |
| packages/api/src/hooks/useCreateActivityStatusRenderer.tsx | Simplifies renderer to remove deprecated parameter handling |
| samples/05.custom-components/g.activity-status/index.html | Updates sample to use hideTimestamp instead of sameTimestampGroup |
| samples/05.custom-components/f.password-input/index.html | Removes nextVisibleActivity parameter from middleware |
| packages/api/src/legacy/LegacyActivityBridge.tsx | Simplifies bridge to remove deprecated parameters |
| packages/api-middleware/src/legacy/activityMiddleware.ts | Updates legacy middleware types |
| packages/api-middleware/src/internal/createActivityPolymiddlewareFromLegacy.tsx | Removes deprecated parameter passing |
| tests/html2/activityGrouping/activityGrouping.legacyActivityStatusMiddleware.html | Updates test to use new parameter names |
| tests/html/transcript.legacyActivityMiddleware.passwordInput.html | Updates test to remove deprecated parameters |
| docs/HOOKS.md | Adds deprecation notice for useRenderActivity hook |
| CHANGELOG.md | Documents the breaking change removal |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
compulim
changed the title
activityMiddleware.nextVisibleActivityactivityMiddleware.nextVisibleActivity and activityMiddleware.sameTimestampGroup
OEvgeny
previously approved these changes
Sep 2, 2025
OEvgeny
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Breaking changes
activityStatusMiddleware.nextVisibleActivityandactivityStatusMiddleware.sameTimestampGroupis removed after deprecation, in PR #5565, by @compulimRemoved
activityStatusMiddleware.nextVisibleActivityandactivityStatusMiddleware.sameTimestampGroupis being deprecated and will be removed on or after 2022-07-22, in PR #4362, by @compulimDescription
Removing deprecated
nextVisibleActivityandsameTimestampGroup.Design
Specific Changes
nextVisibleActivityandsameTimestampGroupI have added tests and executed them locallyCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)