Skip to content

Feedback form aria-label computed value does not match on screen text#5567

Merged
OEvgeny merged 18 commits intomicrosoft:mainfrom
lexi-taylor:main
Sep 12, 2025
Merged

Feedback form aria-label computed value does not match on screen text#5567
OEvgeny merged 18 commits intomicrosoft:mainfrom
lexi-taylor:main

Conversation

@lexi-taylor
Copy link
Copy Markdown
Contributor

@lexi-taylor lexi-taylor commented Sep 2, 2025

Changelog Entry

Description

  • Aria label for feedback form send box was not announcing the header, placeholder and footer
  • Aria label was only announcing the placeholder

Specific Changes

  • Adding id attributes to elements missing them
  • Adding aria-labelledby to feedback for sendbox computed using header, placeholder and footer text
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Comment thread packages/component/src/Attachment/Text/private/Markdownable.tsx Outdated
OEvgeny
OEvgeny previously approved these changes Sep 3, 2025
OEvgeny
OEvgeny previously approved these changes Sep 3, 2025
Comment thread packages/component/src/ActivityFeedback/private/FeedbackForm.tsx Outdated
Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test this with the following browser matrix. We usually don't have capacity testing this changes in release testing.

  • Edge + Narrator
  • Chrome + NVDA
  • macOS Safari + VoiceOver
  • iOS Safari + VoiceOver
  • Android + TalkBack

OEvgeny
OEvgeny previously approved these changes Sep 9, 2025
@OEvgeny OEvgeny merged commit 5d2e95f into microsoft:main Sep 12, 2025
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants