Sanitize URL from URL.createObjectURL()#5568
Merged
compulim merged 6 commits intomicrosoft:mainfrom Sep 3, 2025
Merged
Conversation
OEvgeny
reviewed
Sep 3, 2025
OEvgeny
approved these changes
Sep 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements blob URL sanitization to enhance security by enforcing content type sanitization when creating blob URLs. The key security concern is that blob URLs can bypass Content Security Policy restrictions, so proper content type sanitization prevents potential abuse.
- Added ESLint rules to restrict direct usage of
URL.createObjectURL()without proper sanitization - Implemented content type sanitization across all blob URL creation points in the codebase
- Converted
ImageAttachmentcomponent andreadDataURIToBlobutility from JavaScript to TypeScript
Reviewed Changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.eslintrc.production.yml |
Added ESLint rule to restrict URL.createObjectURL usage |
packages/component/src/Utils/readDataURIToBlob.ts |
Converted to TypeScript with improved type safety |
packages/component/src/Attachment/ImageAttachment.tsx |
Converted to TypeScript with content type sanitization for image blobs |
packages/component/src/Attachment/ImageAttachment.js |
Removed JavaScript version |
packages/core/src/sagas/sendMessageToPostActivitySaga.ts |
Added content type sanitization for file attachments |
packages/component/src/hooks/useSendFiles.ts |
Added content type sanitization for file uploads |
| Multiple style files | Added ESLint disable comments for hardcoded content cases |
| Test files | Added comprehensive tests for content type sanitization behavior |
CHANGELOG.md |
Updated with PR information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Description
Add content type sanitization when creating blob URL.
Specific Changes
.eslintrc.ymlto restrict usage onURL.createObjectURL<ImageAttachment>andreadDataURIToBlobto TypeScriptCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)