Skip to content

[Fat module] fluent-theme should imports from bundle only#5584

Merged
compulim merged 7 commits intomainfrom
feat-fluent-theme-from-bundle
Sep 18, 2025
Merged

[Fat module] fluent-theme should imports from bundle only#5584
compulim merged 7 commits intomainfrom
feat-fluent-theme-from-bundle

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Sep 17, 2025

Changelog Entry

Added

  • fluent-theme: Changed dependencies to import solely from the "bundle" package, in PR #5584, by @compulim

Description

This is for preparing of the "fat module" bundling rework.

In "fat module" world, fluent-theme will depend on bundle package only. Other packages will be (eventually) fold into bundle.

Design

Specific Changes

  • Exporting some internals via new bundle/internal exports
    • We need to review them to see if we can export them
  • Moved fluent-theme to only depend on botframework-webchat
  • Allowlisted some ESM-only packages in Jest
    • These dependencies were from Adaptive Cards, where it is imported when via the bundle package
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim changed the title [WIP] fluent-theme should depends on bundle only fluent-theme should imports from bundle only Sep 17, 2025
@compulim compulim changed the title fluent-theme should imports from bundle only [Fat module] fluent-theme should imports from bundle only Sep 17, 2025
@compulim compulim marked this pull request as ready for review September 17, 2025 20:38
Comment thread packages/bundle/src/boot/exports/internal.ts
Comment thread packages/fluent-theme/tsup.config.ts Outdated
OEvgeny
OEvgeny previously approved these changes Sep 17, 2025
OEvgeny
OEvgeny previously approved these changes Sep 18, 2025
@compulim compulim merged commit 63284ee into main Sep 18, 2025
165 of 172 checks passed
@compulim compulim deleted the feat-fluent-theme-from-bundle branch September 18, 2025 07:42
@compulim compulim mentioned this pull request Sep 19, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants