Conversation
This reverts commit 26227ef.
compulim
commented
Sep 20, 2025
OEvgeny
reviewed
Sep 20, 2025
OEvgeny
approved these changes
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
api:botframework-webchat-api/hookbundle:botframework-webchat/component,botframework-webchat/decorator(internal-use),botframework-webchat/hookcomponent:botframework-webchat-component/component,botframework-webchat-component/hookDescription
This PR pave the way to improve the bundling scenario for "fat" module:
<script type="module">.Design
/bundle/boot/The folder has these designs in mind:
Implementation:
/actual/contains building blocks/actual/(component|hook)/(full|minimal)some blocks may have 2 flavors: full and minimalfullin based onminimal/exports/imports from/actual/to form named exports/exports/do not exports minimal (because treeshaking should work), however, for convenience reasons,/exports/minimaldo exists and is the base of/exports/index/exports/index/will exportComponentsandhooks, they are imported from/exports/(component|hook)/iife/imports from/exports/to form IIFE/iife/webchat-es5is based on/iife/webchat/iife/webchatis not based on minimal/iife/(webchat|webchat-minimal)is based on/exports/(index|minimal)Specific Changes
/boot/microsoft-cognitiveservices-speech-sdk@1.45.0, previous was picking up1.17.0api: Exportedhooksviabotframework-webchat-api/hookbundle: ExportedComponentsviabotframework-webchat/componentbundle: Exporteddecoratorviabotframework-webchat/decoratorbundle: Exportedhooksviabotframework-webchat/hookbundle: Cleaned up and unified/boot/for IIFE and CJS/ESMcomponent: ExportedComponentsviabotframework-webchat-component/componentcomponent: Exportedhooksviabotframework-webchat-component/hookcomponent: Fixed some typing issues in JSAbsoluteTime,RelativeTime,UITracker,useForceRenderAtInterval,useNonce,BasicConnectivityStatus,BasicToasterfluent-theme: Imported frombotframework-webchat/decoratorinstead ofbotframework-webchat/internalwhen availablestyles: Slightly better code splitting supportesbuild: SupportoutDirWithTempfor output folder other thandistI have added tests and executed them locallyCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)