Conversation
OEvgeny
commented
Oct 7, 2025
compulim
reviewed
Oct 8, 2025
compulim
reviewed
Oct 8, 2025
compulim
reviewed
Oct 8, 2025
compulim
reviewed
Oct 8, 2025
compulim
reviewed
Oct 8, 2025
compulim
reviewed
Oct 8, 2025
compulim
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed published package types containing internal package references, in PR #5610, by @OEvgeny
Description
This PR adds a layer of bundling for our types as well as an extra validation layer to ensure we do not leak
@msinternal/*packages type references to the outside.Design
As to the date
tsupdoes not resolve external package types which is stated in their docs:I've tried the above mentioned experimental
--dts-resolveflag without any luck. So the only option seems to shop around for the solutions available.The
dtsrollpackage is designed to modify generated definition files in place according to thepackage.jsondependencies definitions.I shuffled a bit dependencies definitions in the
package.jsonfiles we have, but overall dependencies changes are optional except for thebundlepackage.I also removed Webpack 4 legacy entries for internal packages as these packages should be bundled and such entries trip
dtsrollfor some reason.Specific Changes
package.jsonfiles to includedtsrolltransform steppackage.jsonfiles to include validation stepcreateComponentIconschema type as the resulting type was rather complexcreateComponentIconusage as the old is not compatible with our precommit checktsdto use correct resolution strategy-
CHANGELOG.mdI have updated documentationReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed