Skip to content

feat: bundle internal packages types #5610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OEvgeny merged 12 commits into from
Oct 8, 2025
Merged

feat: bundle internal packages types #5610

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a370cc5
feat: bundle internal packages types
OEvgeny Oct 7, 2025
2947cbe
No quiet for dts validation
OEvgeny Oct 7, 2025
f188d8e
Fix warning and npm command call
OEvgeny Oct 7, 2025
95e52e2
Bring back quiet flag
OEvgeny Oct 7, 2025
562479f
Changelog
OEvgeny Oct 7, 2025
4e82abe
fix tsd
OEvgeny Oct 7, 2025
3a9f929
Rework component icon creation to avoid complex schema type
OEvgeny Oct 7, 2025
085725c
Fix core tsd
OEvgeny Oct 7, 2025
af784fa
Switch createIconComponent usage to union
OEvgeny Oct 8, 2025
259fab2
fix issue type for consumers of createIconComponent
OEvgeny Oct 8, 2025
71a9833
Final fix for componentIcon
OEvgeny Oct 8, 2025
727d4e1
apply suggestions
OEvgeny Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@ Notes: web developers are advised to use [`~` (tilde range)](https://github.com/
- Fixed Composer props types not resolving correctly in React 16 in PR [#5580](https://github.com/microsoft/BotFramework-WebChat/pull/5580),
by [@lexi-taylor](https://github.com/lexi-taylor)
- Fixed `npm start` may fail subsequently as builds are not fully flushed to `/dist/`, in PR [#5599](https://github.com/microsoft/BotFramework-WebChat/pull/5599), by [@compulim](https://github.com/compulim)
- Fixed published package types containing internal package references, in PR [#5610](https://github.com/microsoft/BotFramework-WebChat/pull/5610), by [@OEvgeny](https://github.com/OEvgeny)

### Removed

Expand Down
213 changes: 201 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@
"cross-env": "^10.0.0",
"diff": "^8.0.2",
"dotenv": "^17.2.1",
"dtsroll": "^1.4.1",
"eslint": "^8.57.1",
"eslint-config-prettier": "^10.1.8",
"eslint-plugin-import": "^2.32.0",
Expand Down
Loading
Loading