Skip to content

Set VRT per-pixel tolerance to 0.06#5626

Merged
OEvgeny merged 1 commit intomainfrom
fix-pixel-tolerance
Nov 1, 2025
Merged

Set VRT per-pixel tolerance to 0.06#5626
OEvgeny merged 1 commit intomainfrom
fix-pixel-tolerance

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Nov 1, 2025

Changelog Entry

(No changelog for test infrastructure change.)

Description

We recycle Chrome tab during visual regression test for performance reason. However, it seems the recycle would also affect how Chrome render SVGs.

We are increasing tolerance from 0.05 to 0.06 for a pixel change inside the file attach icon.

Specific Changes

  • Update per-pixel tolerance to 0.06 from 0.05
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review November 1, 2025 01:13
@OEvgeny OEvgeny merged commit e5e0f7c into main Nov 1, 2025
29 checks passed
@OEvgeny OEvgeny deleted the fix-pixel-tolerance branch November 1, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants