Skip to content

Bump dependencies#5659

Merged
compulim merged 34 commits intomainfrom
bump-deps2
Dec 19, 2025
Merged

Bump dependencies#5659
compulim merged 34 commits intomainfrom
bump-deps2

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Dec 19, 2025

Changelog Entry

Changed

Description

Bump dependencies.

Design

Pull request validation bumping to Node.js 24

We no longer see Jest errors which forced us to pin to Node.js 18. We are bumping to 24.

Moving to Microsoft Container Registry

We have a security requirement to use images from mcr.microsoft.com. However, MCR does not mirror official Node.js image > 18.

When bumping selfsigned, it seems it need a newer version of Node.js that support Web Crypto.

image

If we are right, we need to bump to a newer Node.js. As MCR don't mirror official image > 18, we have to use images by MCR. In this PR, we are using 24-bookworm.

Happy DOM configuration

After bumping happy-dom, it starts throwing error when <script> is injected. The error said the JS file is not being downloaded, which is the right behavior. The JS file is not intended to be downloaded or executed.

We are setting the window.happyDOM.settings.handleDisabledFileLoadingAsSuccess = true to remove the error.

selfsigned updated its signature

generate() function is now async generate().

Disabling some React rules

# The rule is preventing read access to refs inside the render loop.
# For optimization, we are heavy on ref usage.
react-hooks/refs: off

# This rule does not understand validateProps and falsely claim validateProps is causing mutations.
react-hooks/preserve-manual-memoization: off

package-lock.json does not contains cross-platform packages

Node.js 24 requires package-lock.json must list cross-platform packages.

We run npm install under Node.js 24 and obtained that package-lock.json snapshot. We did not rebuild package-lock.json as it contains a lot of historical value.

Specific Changes

  • Remove pin dependencies on typescript@~5.8.3
  • Run npm run bump
  • Fixed some tests (refer to Design section)
  • Format PULL_REQUEST_TEMPLATE.md
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review December 19, 2025 05:13
@compulim compulim changed the title Bump deps2 Bump dependencies Dec 19, 2025
@compulim compulim merged commit 025429f into main Dec 19, 2025
45 of 54 checks passed
@compulim compulim deleted the bump-deps2 branch December 19, 2025 17:17
@compulim compulim mentioned this pull request Dec 19, 2025
11 tasks
@compulim compulim mentioned this pull request Mar 5, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants