-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Speech to speech: Mute functionality #5688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3c5d7e7
mute funcitonality in s2s
pranavjoshi001 aec1249
changelog file
pranavjoshi001 14da8a4
lint resolved
pranavjoshi001 f1259fb
Merge branch 'main' into feature/s2s-mute
pranavjoshi001 f35f158
Merge branch 'main' into feature/s2s-mute
pranavjoshi001 a8e96b8
Merge branch 'feature/s2s-mute' of https://github.com/pranavjoshi001/…
pranavjoshi001 f266871
revert UI changes and keeping core mute/unmute functionality
pranavjoshi001 ab82cb6
revert localized mute string
pranavjoshi001 c08c225
expose mute/unmute API for consumer
pranavjoshi001 c70f64f
comment resolved
pranavjoshi001 b68593f
sorting
pranavjoshi001 4bee074
e2e test case added
pranavjoshi001 43d57f7
Merge branch 'main' into feature/s2s-mute
pranavjoshi001 60b8e5b
Merge branch 'main' into feature/s2s-mute
compulim 101303b
Merge branch 'main' into feature/s2s-mute
compulim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import useWebChatAPIContext from './internal/useWebChatAPIContext'; | ||
|
|
||
| /** | ||
| * Hook to mute voice mode (stops microphone input but keeps connection alive with silent chunks). | ||
| * The session remains active and can be unmuted to resume listening. | ||
| */ | ||
| export default function useMuteVoice(): () => void { | ||
| return useWebChatAPIContext().muteVoice; | ||
|
pranavjoshi001 marked this conversation as resolved.
Outdated
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import useWebChatAPIContext from './internal/useWebChatAPIContext'; | ||
|
|
||
| /** | ||
| * Hook to unmute voice mode (resumes microphone input after muting). | ||
| * This reactivates speech-to-speech listening. | ||
| */ | ||
| export default function useUnmuteVoice(): () => void { | ||
|
pranavjoshi001 marked this conversation as resolved.
Outdated
|
||
| return useWebChatAPIContext().unmuteVoice; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog entry says mute/unmute was added "via
useRecorderhook", butuseRecorderis an internal/private implementation detail underproviders/SpeechToSpeech/private. For consumers, the new public surface appears to beuseVoiceRecordingMuted(and/or themuteVoiceRecording/unmuteVoiceRecordingactions). Consider rewording this entry to reference the public API to avoid confusing integrators.