fix: merging main to dev#814
Merged
Merged
Conversation
* feat: Implementation of Configurable Logging Control via Flag (#756) * Implementation of Configurable Logging Control via Flag * bicep updated * updated bicep * updated custom bicep * Fix typo in CustomizingAzdParameters.md (#772) * Update src/App/app.py fixed blank string issue Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: Add Troubleshooting Guide for Log Analytics Workspace Deletion Issues (#758) * Add files via upload * Update deployment guide with replication note Added note about disabling replication before deleting resources. * Fix typo in LogAnalyticsReplicationDisable.md * Fix formatting of note in Deployment Guide --------- Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> * Update CosmosDB parameters for improved redundancy and location handling and resolved sql server redeployment issue * update main.json * Update infra/main.bicep Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update infra/main.bicep Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * resolved copilot comments --------- Co-authored-by: Prajwal-Microsoft <v-dcprajwal@microsoft.com> Co-authored-by: AjitPadhi-Microsoft <v-padhiajit@microsoft.com> Co-authored-by: Thanusree-Microsoft <168087422+Thanusree-Microsoft@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Abdul-Microsoft <v-amujeebta@microsoft.com>
docs: Added banner for archival
ci: update deploy and test workflow for WAF deployment testing
ci: update environment variable for AI service location in deployment workflow
Switched from using a pre-built image to a custom Dockerfile for the development container.
Remove Yarn repository to prevent GPG key expiration issues.
fix: Code space issue fix
Added links to AI and Data Engineering playbooks for best practices.
docs: Update README with AI and Data playbook links
chore: delete Create-Release workflow due to codfish security incident
VishalSh-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
aniaroramsft,
dgp10801,
nchandhi and
toherman-msft
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several infrastructure and documentation updates to improve high availability, redundancy, and clarity for deploying the solution accelerator. The main changes include enhanced Cosmos DB failover support, improved handling of Log Analytics workspace deletion, and updates to deployment parameters and documentation.
Infrastructure improvements:
cosmosLocation) and secondary (secondaryCosmosLocation) Cosmos DB regions for high availability and failover, with corresponding parameter and variable updates ininfra/main.bicepand parameter files. [1] [2] [3] [4]premiumwhen scalability is enabled, and adjusted App Service and Search Service SKUs for better cost and redundancy alignment. [1] [2] [3]Redundancy and resource deletion guidance:
docs/LogAnalyticsReplicationDisable.md, detailing how to disable Log Analytics workspace replication before deletion to avoid failures, and referenced it in the deployment guide. [1] [2]Documentation updates:
README.mdthat the repository is no longer maintained, and included links to Microsoft AI/Data playbooks. [1] [2]Dev container and CI/CD changes:
.devcontainerconfiguration to use a custom Dockerfile that removes the Yarn repository to avoid GPG key issues. [1] [2]Create-Release.ymlGitHub Actions workflow.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation