Skip to content

Commit 1e0fd7c

Browse files
committed
do not merge: gtests: Tweak test name to reflect name change of BBR to BBR3.
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
1 parent 2285fcb commit 1e0fd7c

2 files changed

Lines changed: 23 additions & 23 deletions

File tree

gtests/net/tcp/bbr/nsperf/graph_tests.sh

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ if [[ $tests == *"coexist"* ]]; then
4646
# graph tput of 1 cubic, 1 BBR at a range of buffer depths:
4747
# (bw=50M, rtt=30ms, buf={...}xBDP)
4848
rm -f $outdir/coexist.*
49-
for cc_combo in cubic:1,bbr1:1 cubic:1,bbr:1; do
49+
for cc_combo in cubic:1,bbr1:1 cubic:1,bbr3:1; do
5050
for bdp_of_buf in 0.1 1 2 4 8 16; do
5151
echo -n "$bdp_of_buf " >> $outdir/coexist.${cc_combo}
5252
grep THROUGHPUT $indir/coexist/${cc_combo}/${bdp_of_buf}/netperf.out.1.txt | \
@@ -68,7 +68,7 @@ set output '$OUTPNG'"
6868
set ylabel 'throughput in Mbit/sec'\n\
6969
set yrange [0:50]\n\
7070
plot '$outdir/coexist.cubic:1,bbr1:1' u 1:2 t 'bbr1' w lp lw 2 pt 7 lt rgb \"#abd9e9\",\
71-
'$outdir/coexist.cubic:1,bbr:1' u 1:2 t 'bbr' w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
71+
'$outdir/coexist.cubic:1,bbr3:1' u 1:2 t 'bbr3' w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
7272
\n" > $outdir/coexist.gnuplot
7373

7474
gnuplot -persist $outdir/coexist.gnuplot
@@ -84,7 +84,7 @@ if [[ $tests == *"random_loss"* ]]; then
8484
rm -f $outdir/random_loss.*
8585
loss_rates="0.00001 0.0001 0.001 0.01 0.1 0.2 0.5 1 2 3 10 15 20"
8686
for loss_rate in $loss_rates; do
87-
for cc_name in cubic bbr1 bbr; do
87+
for cc_name in cubic bbr1 bbr3; do
8888
cc="${cc_name}:1"
8989
sumd="$indir/random_loss/${cc}/${loss_rate}/summary/"
9090
mkdir -p $sumd
@@ -110,14 +110,14 @@ set output '$OUTPNG'"
110110
set ytics nomirror\n\
111111
set grid\n\
112112
set logscale x\n\
113-
set title 'cubic, bbr1, and bbr throughput with random loss'\n\
113+
set title 'cubic, bbr1, and bbr3 throughput with random loss'\n\
114114
set xlabel 'random loss rate, in percent'\n\
115115
set ylabel 'throughput in Mbit/sec'\n\
116116
set yrange [0:1000]\n\
117117
set xrange [:20]\n\
118118
plot '$outdir/random_loss.cubic:1' u 1:2 t 'cubic' w lp lw 2 pt 7 lt rgb \"#d7191c\",\
119119
'$outdir/random_loss.bbr1:1' u 1:2 t 'bbr1' w lp lw 2 pt 7 lt rgb \"#abd9e9\",\
120-
'$outdir/random_loss.bbr:1' u 1:2 t 'bbr' w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
120+
'$outdir/random_loss.bbr3:1' u 1:2 t 'bbr3' w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
121121
\n" > $outdir/random_loss.gnuplot
122122

123123
gnuplot -persist $outdir/random_loss.gnuplot
@@ -133,7 +133,7 @@ if [[ $tests == *"shallow"* ]]; then
133133
# BDP is 1G*100ms = 8256 packets
134134
rm -f $outdir/shallow_buf.*
135135
for num_flows in 1 10 30 60 100; do
136-
for cc_name in cubic bbr1 bbr; do
136+
for cc_name in cubic bbr1 bbr3; do
137137
echo -n "$num_flows " >> $outdir/shallow_buf.${cc_name}
138138
d="$indir/shallow/${cc_name}:${num_flows}/${num_flows}"
139139
infile=${d}/ss.log outdir=${d}/ ./ss_log_parser.py
@@ -151,14 +151,14 @@ set output '$OUTPNG'"
151151
set ytics nomirror\n\
152152
set grid\n\
153153
set logscale x\n\
154-
set title 'cubic, bbr1, and bbr retransmit rate in shallow buffers'\n\
154+
set title 'cubic, bbr1, and bbr3 retransmit rate in shallow buffers'\n\
155155
set xlabel 'number of flows'\n\
156156
set ylabel 'retransmit rate (percent)'\n\
157157
set yrange [0:15]\n\
158158
set xrange [:]\n\
159159
plot '$outdir/shallow_buf.cubic' u 1:2 t 'cubic' w lp lw 2 pt 7 lt rgb \"#d7191c\",\
160160
'$outdir/shallow_buf.bbr1' u 1:2 t 'bbr1' w lp lw 2 pt 7 lt rgb \"#abd9e9\",\
161-
'$outdir/shallow_buf.bbr' u 1:2 t 'bbr' w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
161+
'$outdir/shallow_buf.bb3' u 1:2 t 'bbr3' w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
162162
\n" > $outdir/shallow_buf.gnuplot
163163

164164
gnuplot -persist $outdir/shallow_buf.gnuplot
@@ -174,7 +174,7 @@ if [[ $tests == *"bufferbloat"* ]]; then
174174
# (bw=50M, rtt=30ms, buf={...}xBDP)
175175
rm -f $outdir/bufferbloat.*
176176
for bdp_of_buf in 1 10 50 100; do
177-
for cc_name in cubic bbr1 bbr; do
177+
for cc_name in cubic bbr1 bbr3; do
178178
echo -n "$bdp_of_buf " >> $outdir/bufferbloat.${cc_name}
179179
num_flows=2
180180
d="$indir/bufferbloat/${cc_name}:${num_flows}/${bdp_of_buf}"
@@ -192,14 +192,14 @@ set output '$OUTPNG'"
192192
set key top left\n\
193193
set ytics nomirror\n\
194194
set grid\n\
195-
set title 'cubic, bbr1, and bbr median RTT'\n\
195+
set title 'cubic, bbr1, and bbr3 median RTT'\n\
196196
set xlabel 'buffer size (as a multiple of BDP)'\n\
197197
set ylabel 'median srtt sample (ms)'\n\
198198
set yrange [0:]\n\
199199
set xrange [1:100]\n\
200200
plot '$outdir/bufferbloat.cubic' u 1:2 t 'cubic' w lp lw 2 pt 7 lt rgb \"#d7191c\",\
201201
'$outdir/bufferbloat.bbr1' u 1:2 t 'bbr1' w lp lw 2 pt 7 lt rgb \"#abd9e9\",\
202-
'$outdir/bufferbloat.bbr' u 1:2 t 'bbr' w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
202+
'$outdir/bufferbloat.bbr3' u 1:2 t 'bbr3' w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
203203
\n" > $outdir/bufferbloat.gnuplot
204204

205205
gnuplot -persist $outdir/bufferbloat.gnuplot
@@ -214,7 +214,7 @@ if [[ $tests == *"ecn_bulk"* ]]; then
214214
# graph p50 for range of flow counts.
215215
# (bw=1G, rtt=1ms, num_flows={...})
216216
# For each CC and flow count, show the median of the p50 RTT from N trials.
217-
for cc_name in dctcp bbr1 bbr; do
217+
for cc_name in dctcp bbr1 bbr3; do
218218
for num_flows in 1 4 10 40 100; do
219219
sumd="$indir/ecn_bulk/${cc_name}/${num_flows}/summary/"
220220
mkdir -p $sumd
@@ -243,14 +243,14 @@ set output '$OUTPNG'"
243243
set ytics nomirror\n\
244244
set grid\n\
245245
set logscale x\n\
246-
set title 'dctcp, bbr1, and bbr median RTT'\n\
246+
set title 'dctcp, bbr1, and bbr3 median RTT'\n\
247247
set xlabel 'number of flows'\n\
248248
set ylabel 'median srtt sample (ms)'\n\
249249
set yrange [0:]\n\
250250
set xrange [1:100]\n\
251251
plot '$outdir/ecn_bulk.dctcp' u 1:2 t 'dctcp' w lp lw 2 pt 7 lt rgb \"#d7191c\",\
252252
'$outdir/ecn_bulk.bbr1' u 1:2 t 'bbr1' w lp lw 2 pt 7 lt rgb \"#abd9e9\",\
253-
'$outdir/ecn_bulk.bbr' u 1:2 t 'bbr' w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
253+
'$outdir/ecn_bulk.bbr3' u 1:2 t 'bbr3' w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
254254
\n" > $outdir/ecn_bulk_rtt.gnuplot
255255

256256
gnuplot -persist $outdir/ecn_bulk_rtt.gnuplot
@@ -260,7 +260,7 @@ set output '$OUTPNG'"
260260
#######
261261
# show ECN support can keep queues very low:
262262
# graph median of retrans rates across N trials:
263-
for cc_name in dctcp bbr1 bbr; do
263+
for cc_name in dctcp bbr1 bbr3; do
264264
for num_flows in 1 4 10 40 100; do
265265
sumd="$indir/ecn_bulk/${cc_name}/${num_flows}/summary/"
266266
mkdir -p $sumd
@@ -287,14 +287,14 @@ set output '$OUTPNG'"
287287
set key top left\n\
288288
set grid\n\
289289
set logscale x\n\
290-
set title 'dctcp, bbr1, and bbr retransmit rate'\n\
290+
set title 'dctcp, bbr1, and bbr3 retransmit rate'\n\
291291
set xlabel 'number of flows'\n\
292292
set ylabel 'retransmit rate (percent)'\n\
293293
set yrange [:]\n\
294294
set xrange [1:100]\n\
295295
plot '$outdir/ecn_bulk.retrans.dctcp' u 1:2 t 'dctcp' axis x1y1 w lp lw 2 pt 7 lt rgb \"#d7191c\",\
296296
'$outdir/ecn_bulk.retrans.bbr1' u 1:2 t 'bbr1' axis x1y1 w lp lw 2 pt 7 lt rgb \"#abd9e9\",\
297-
'$outdir/ecn_bulk.retrans.bbr' u 1:2 t 'bbr' axis x1y1 w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
297+
'$outdir/ecn_bulk.retrans.bbr3' u 1:2 t 'bbr3' axis x1y1 w lp lw 2 pt 7 lt rgb \"#2c7bb6\"\
298298
\n" > $outdir/ecn_bulk_retrans.gnuplot
299299

300300
gnuplot -persist $outdir/ecn_bulk_retrans.gnuplot

gtests/net/tcp/bbr/nsperf/run_tests.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash
22
#
3-
# Run a set of tests with bbr1, bbr, cubic, dctcp.
3+
# Run a set of tests with bbr1, bbr3, cubic, dctcp.
44
# By default, runs all tests:
55
# ./run_tests.sh
66
# But you can also run a subset of tests by setting the "tests"
@@ -34,7 +34,7 @@ if [[ $tests == *"coexist"* ]]; then
3434
# graph tput of 1 cubic, 1 bbr at a range of buffer depths:
3535
# (bw=50M, rtt=30ms, buf={...}xBDP)
3636
# [run for a very long time, 10minutes, to find convergence...]
37-
for cc_combo in cubic:1,bbr1:1 cubic:1,bbr:1; do
37+
for cc_combo in cubic:1,bbr1:1 cubic:1,bbr3:1; do
3838
for bdp_of_buf in 0.1 1 2 4 8 16; do
3939
cmd=""
4040
cc=$cc_combo # mix of CCs in this experiment
@@ -62,7 +62,7 @@ if [[ $tests == *"random_loss"* ]]; then
6262
# graph tput of cubic, bbr at a range of random loss rates
6363
# (bw=1G, rtt=100ms, loss={....}
6464
for rep in `seq 1 10`; do
65-
for cc_name in cubic bbr1 bbr; do
65+
for cc_name in cubic bbr1 bbr3; do
6666
loss_rates="0.00001 0.0001 0.001 0.01 0.1 0.2 0.5 1 2 3 10 15 20"
6767
for loss_rate in $loss_rates; do
6868
cmd=""
@@ -94,7 +94,7 @@ if [[ $tests == *"shallow"* ]]; then
9494
# graph retransmit rate for range of flow counts
9595
# (bw=1G, rtt=100ms, buf=1ms, num_flows={...})
9696
# BDP is 1G*100ms = 8256 packets
97-
for cc_name in cubic bbr1 bbr; do
97+
for cc_name in cubic bbr1 bbr3; do
9898
for num_flows in 1 10 30 60 100; do
9999
cmd=""
100100
cc=${cc_name}:${num_flows}
@@ -123,7 +123,7 @@ if [[ $tests == *"bufferbloat"* ]]; then
123123
# graph p50 RTT for two flows using either cubic or bbr,
124124
# at a range of buffer depths.
125125
# (bw=50M, rtt=30ms, buf={...}xBDP)
126-
for cc_name in cubic bbr1 bbr; do
126+
for cc_name in cubic bbr1 bbr3; do
127127
for bdp_of_buf in 1 10 50 100; do
128128
cmd=""
129129
cc=${cc_name}:2 # 2 flows
@@ -152,7 +152,7 @@ if [[ $tests == *"ecn_bulk"* ]]; then
152152
# graph p50 and p95 RTT (and retx, tput, fairness) for range of flow counts
153153
# (bw=1G, rtt=1ms, num_flows={...})
154154
for rep in `seq 1 10`; do
155-
for cc_name in bbr bbr1 dctcp; do
155+
for cc_name in bbr3 bbr1 dctcp; do
156156
for num_flows in 1 4 10 40 100; do
157157
# Inside the child/test namespaces, enable ECN for
158158
# both active and passive connections:

0 commit comments

Comments
 (0)