Remove unused get_responder() from RpcContext and make http_responder.h private (#7827)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: eddyashton <6000239+eddyashton@users.noreply.github.com>
Co-authored-by: Amaury Chamayou <amchamay@microsoft.com>

Author: 3 people

CHANGELOG.md

@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Removed
 
 - Removed `aes_gcm_encrypt()`, `aes_gcm_decrypt()`, and `default_iv` from `ccf::crypto` (#7811).
+- Removed `get_responder()` from the public `ccf::RpcContext` API and made `http_responder.h` a private header (#7818).
 - Removed the `/node/memory` endpoint. This endpoint was originally useful for monitoring SGX enclave memory usage, which is no longer relevant now that SGX support has been removed.
 
 ## [7.0.0-rc1]

include/ccf/rpc_context.h

@@ -7,7 +7,6 @@
 #include "ccf/frame_format.h"
 #include "ccf/http_consts.h"
 #include "ccf/http_header_map.h"
-#include "ccf/http_responder.h"
 #include "ccf/odata_error.h"
 #include "ccf/redirect.h"
 #include "ccf/rest_verb.h"
@@ -83,8 +82,6 @@ namespace ccf
     [[nodiscard]] virtual const ccf::RESTVerb& get_request_verb() const = 0;
     [[nodiscard]] virtual std::string get_request_path() const = 0;
     [[nodiscard]] virtual std::string get_method() const = 0;
-    [[nodiscard]] virtual std::shared_ptr<ccf::http::HTTPResponder>
-    get_responder() const = 0;
 
     /// Returns a map of all PathParams parsed out of the original query path.
     /// For instance if this endpoint was installed at `/foo/{name}/{age}`, and

src/enclave/rpc_sessions.h

@@ -2,14 +2,14 @@
 // Licensed under the Apache 2.0 License.
 #pragma once
 
-#include "ccf/http_responder.h"
 #include "ccf/pal/locking.h"
 #include "ccf/service/node_info_network.h"
 #include "ds/internal_logger.h"
 #include "ds/serialized.h"
 #include "enclave/session.h"
 #include "forwarder_types.h"
 #include "http/http2_session.h"
+#include "http/http_responder.h"
 #include "http/http_session.h"
 #include "node/rpc/custom_protocol_subsystem.h"
 #include "node/session_metrics.h"

src/http/http2_session.h

@@ -2,13 +2,13 @@
 // Licensed under the Apache 2.0 License.
 #pragma once
 
-#include "ccf/http_responder.h"
 #include "ds/internal_logger.h"
 #include "enclave/client_session.h"
 #include "enclave/rpc_map.h"
 #include "error_reporter.h"
 #include "http/http2_types.h"
 #include "http2_parser.h"
+#include "http_responder.h"
 #include "http_rpc_context.h"
 
 namespace http
@@ -352,8 +352,7 @@ namespace http
             verb,
             url,
             std::move(headers),
-            std::move(body),
-            responder);
+            std::move(body));
         }
         catch (std::exception& e)
         {

include/ccf/http_responder.h src/http/http_responder.hinclude/ccf/http_responder.h renamed to src/http/http_responder.h

@@ -2,7 +2,6 @@
 // Licensed under the Apache 2.0 License.
 #pragma once
 
-#include "ccf/http_responder.h"
 #include "ccf/odata_error.h"
 #include "ccf/rpc_context.h"
 #include "ds/actors.h"
@@ -49,8 +48,6 @@ namespace http
 
     std::vector<uint8_t> request_body;
 
-    std::shared_ptr<ccf::http::HTTPResponder> responder = nullptr;
-
     std::vector<uint8_t> serialised_request;
 
     ccf::http::HeaderMap response_headers;
@@ -99,14 +96,12 @@ namespace http
       const std::string_view& url_,
       ccf::http::HeaderMap headers_,
       const std::vector<uint8_t>& body_,
-      const std::shared_ptr<ccf::http::HTTPResponder>& responder_ = nullptr,
       const std::vector<uint8_t>& raw_request_ = {}) :
       RpcContextImpl(s, http_version),
       verb(verb_),
       url(url_),
       request_headers(std::move(headers_)),
       request_body(body_),
-      responder(responder_),
       serialised_request(raw_request_)
     {
       const auto [path_, query_, fragment_] = split_url_path(url);
@@ -202,12 +197,6 @@ namespace http
       return url;
     }
 
-    [[nodiscard]] std::shared_ptr<ccf::http::HTTPResponder> get_responder()
-      const override
-    {
-      return responder;
-    }
-
     template <typename T>
     void _set_response_body(T&& body)
     {
@@ -396,7 +385,6 @@ namespace ccf
       msg.url,
       msg.headers,
       msg.body,
-      nullptr,
       packed);
   }
 

src/http/http_rpc_context.h

@@ -2,13 +2,13 @@
 // Licensed under the Apache 2.0 License.
 #pragma once
 
-#include "ccf/http_responder.h"
 #include "ds/internal_logger.h"
 #include "enclave/client_session.h"
 #include "enclave/rpc_handler.h"
 #include "enclave/rpc_map.h"
 #include "error_reporter.h"
 #include "http_parser.h"
+#include "http_responder.h"
 #include "http_rpc_context.h"
 
 namespace http