What if we used uv to run lots of our ci-checks.sh (#7787)

Co-authored-by: Amaury Chamayou <amchamay@microsoft.com>

Author: eddyashton

scripts/check-cmake-format.sh

@@ -28,24 +28,22 @@ else
   echo "Checking file format in" "$@"
 fi
 
-if [ ! -f "scripts/env/bin/activate" ]
-    then
-        python3 -m venv scripts/env
+if [ ! -x "$(command -v uv)" ]; then
+  echo "uv is required but not installed. See https://docs.astral.sh/uv/getting-started/installation/" >&2
+  exit 1
 fi
 
-source scripts/env/bin/activate
-pip install -U pip
-pip install 'gersemi==0.17.0' 1>/dev/null
+GERSEMI="uvx gersemi@0.17.0"
 
 FILES=$(git ls-files "$@" | grep -e '\.cmake$' -e 'CMakeLists\.txt$')
 
 if $fix ; then
   # shellcheck disable=SC2086
-  gersemi -i $FILES
+  $GERSEMI -i $FILES
   echo "All files formatted!"
 else
   # shellcheck disable=SC2086
-  if gersemi --check $FILES; then
+  if $GERSEMI --check $FILES; then
     echo "All files formatted correctly!"
   else
     echo "Fix formatting by running: scripts/cmake-format-checks.sh -f"

scripts/check-format.sh

@@ -43,17 +43,16 @@ mapfile -t files < <(git ls-files "$@" | grep -e '\.h$' -e '\.hpp$' -e '\.cpp$'
 # --- Format check (parallel) ---
 if [ "${#files[@]}" -eq 0 ]; then
   unformatted_files=""
-elif $fix ; then
-  # In fix mode, format first then check what changed
-  printf '%s\n' "${files[@]}" | xargs -P "$NPROC" -n 50 "$CLANG_FORMAT" -style=file -i
-
-  # Re-check to report which files were fixed
-  unformatted_files=$(git diff --name-only -- "${files[@]}") || true
 else
-  # Check mode: collect filenames from clang-format warnings (parallel)
+  # Check which files need formatting (parallel)
   unformatted_files=$(printf '%s\n' "${files[@]}" | \
     xargs -P "$NPROC" -n 50 "$CLANG_FORMAT" -n -Werror -style=file 2>&1 | \
     sed -n 's/^\(.*\):[0-9]*:[0-9]*:.*/\1/p' | sort -u) || true
+
+  if $fix && [ "$unformatted_files" != "" ]; then
+    # Fix only the files that failed the check
+    echo "$unformatted_files" | xargs -P "$NPROC" -n 50 "$CLANG_FORMAT" -style=file -i
+  fi
 fi
 
 # --- File name check ---

scripts/openapi-checks.sh

@@ -11,9 +11,12 @@ SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 ROOT_DIR=$( dirname "$SCRIPT_DIR" )
 cd "$ROOT_DIR" || exit 1
 
-NPM_DIR=$(mktemp -d) || exit 1
-trap 'rm -rf "$NPM_DIR"' EXIT
-npm install --loglevel=error --no-save --prefix "$NPM_DIR" @apidevtools/swagger-cli 1>/dev/null || exit 1
+if [ ! -x "$(command -v uv)" ]; then
+  echo "uv is required but not installed. See https://docs.astral.sh/uv/getting-started/installation/" >&2
+  exit 1
+fi
 
-find doc/schemas/*.json -exec npx --prefix "$NPM_DIR" swagger-cli validate {} \; || exit 1
-find doc/schemas/gov/*/*.json -exec npx --prefix "$NPM_DIR" swagger-cli validate {} \;
+VALIDATOR="uvx --from openapi-spec-validator openapi-spec-validator"
+
+$VALIDATOR doc/schemas/*.json || exit 1
+$VALIDATOR doc/schemas/gov/*/*.json

scripts/python-format-checks.sh

@@ -17,17 +17,13 @@ SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 ROOT_DIR=$( dirname "$SCRIPT_DIR" )
 cd "$ROOT_DIR" || exit 1
 
-# Ensure venv exists and activate (uses a dedicated venv to allow concurrent runs)
-if [ ! -f "scripts/env-format/bin/activate" ]; then
-  python3 -m venv scripts/env-format
+if [ ! -x "$(command -v uv)" ]; then
+  echo "uv is required but not installed. See https://docs.astral.sh/uv/getting-started/installation/" >&2
+  exit 1
 fi
-source scripts/env-format/bin/activate
-
-pip install -U pip > /dev/null || exit 1
-pip install -U wheel black 1>/dev/null || exit 1
 
 if [ $FIX -ne 0 ]; then
-  git ls-files tests/ python/ scripts/ tla/ | grep -e '\.py$' | xargs black
+  git ls-files tests/ python/ scripts/ tla/ | grep -e '\.py$' | xargs uvx black
 else
-  git ls-files tests/ python/ scripts/ tla/ | grep -e '\.py$' | xargs black --check
+  git ls-files tests/ python/ scripts/ tla/ | grep -e '\.py$' | xargs uvx black --check
 fi

scripts/python-lint-checks.sh

@@ -17,19 +17,13 @@ SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 ROOT_DIR=$( dirname "$SCRIPT_DIR" )
 cd "$ROOT_DIR" || exit 1
 
-# Ensure venv exists and activate (uses a dedicated venv to allow concurrent runs)
-if [ ! -f "scripts/env-lint/bin/activate" ]; then
-  python3 -m venv scripts/env-lint || exit 1
+if [ ! -x "$(command -v uv)" ]; then
+  echo "uv is required but not installed. See https://docs.astral.sh/uv/getting-started/installation/" >&2
+  exit 1
 fi
-source scripts/env-lint/bin/activate || exit 1
-
-pip install -U pip > /dev/null || exit 1
-pip install -U wheel ruff 1>/dev/null || exit 1
-pip install -U -r tests/requirements.txt 1>/dev/null || exit 1
-pip install -U ./python 1>/dev/null || exit 1
 
 if [ $FIX -ne 0 ]; then
-  ruff check --fix python/ tests/
+  uvx ruff check --fix python/ tests/
 else
-  ruff check python/ tests/
+  uvx ruff check python/ tests/
 fi

scripts/python-types-checks.sh

@@ -11,14 +11,9 @@ SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 ROOT_DIR=$( dirname "$SCRIPT_DIR" )
 cd "$ROOT_DIR" || exit 1
 
-# Ensure venv exists and activate (uses a dedicated venv to allow concurrent runs)
-if [ ! -f "scripts/env-types/bin/activate" ]; then
-  python3 -m venv scripts/env-types || exit 1
+if [ ! -x "$(command -v uv)" ]; then
+  echo "uv is required but not installed. See https://docs.astral.sh/uv/getting-started/installation/" >&2
+  exit 1
 fi
-source scripts/env-types/bin/activate || exit 1
 
-pip install -U pip > /dev/null || exit 1
-pip install -U wheel pytest-mypy mypy 1>/dev/null || exit 1
-pip install ./python 1>/dev/null || exit 1
-
-git ls-files python/ | grep -e '\.py$' | xargs mypy
+git ls-files python/ | grep -e '\.py$' | xargs uvx --with ./python --with pytest mypy