Rename HashProvider::Hash to HashProvider::hash (#7660)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>

Author: Copilot

CHANGELOG.md

@@ -14,6 +14,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - `GET` and `HEAD` `/node/ledger-chunk?since={seqno}` and `/node/ledger-chunk/{chunk_name}` endpoints, gated by the `LedgerChunkDownload` RPC interface operator feature. See [documentation](https://microsoft.github.io/CCF/main/operations/ledger_snapshot.html#download-endpoints) for more detail.
 - `GET` and `HEAD` `/node/ledger-chunk/{chunk_name}` and `/node/snapshot/{snapshot_name}` now support the `Want-Repr-Digest` request header and return the `Repr-Digest` response header accordingly (RFC 9530). Supported algorithms are `sha-256`, `sha-384`, and `sha-512`. If no supported algorithm is requested, the server defaults to `sha-256` (#7650).
 
+### Changed
+
+- `ccf::crypto::HashProvider::Hash()` has been renamed to `ccf::crypto::HashProvider::hash()` for consistency with the rest of the API (#7660).
+
 ### Fixed
 
 - Only rollback uncommittable indices during become_leader (#7620)

include/ccf/crypto/hash_provider.h

@@ -21,7 +21,7 @@ namespace ccf::crypto
      * @param size The size of @p data
      * @param type The type of hash to compute
      */
-    virtual HashBytes Hash(
+    virtual HashBytes hash(
       const uint8_t* data, size_t size, MDType type) const = 0;
 
     virtual ~HashProvider() = default;

js/ccf-app/src/consensus.ts

@@ -31,4 +31,4 @@ export const getViewForSeqno = ccf.consensus.getViewForSeqno.bind(
   ccf.consensus,
 );
 
-export { TransactionStatus } from "./global";
+export type { TransactionStatus } from "./global";

js/ccf-app/src/crypto.ts

@@ -132,7 +132,7 @@ export const pubEddsaJwkToPem = ccf.crypto.pubEddsaJwkToPem;
  */
 export const eddsaJwkToPem = ccf.crypto.eddsaJwkToPem;
 
-export {
+export type {
   WrapAlgoParams,
   AesKwpParams,
   RsaOaepParams,

js/ccf-app/src/historical.ts

@@ -48,4 +48,4 @@ export const dropCachedStates = ccf.historical.dropCachedStates.bind(
   ccf.historical,
 );
 
-export { HistoricalState, Receipt, Proof, ProofElement } from "./global";
+export type { HistoricalState, Receipt, Proof, ProofElement } from "./global";

js/ccf-app/src/kv.ts

@@ -182,4 +182,4 @@ export function typedKvSet<K, V>(
  */
 export const rawKv = ccf.kv;
 
-export { KvMap, KvSet, KvMaps } from "./global";
+export type { KvMap, KvSet, KvMaps } from "./global";

src/crypto/openssl/ec_key_pair.cpp

@@ -164,7 +164,7 @@ namespace ccf::crypto
       md_type = get_md_for_ec(get_curve_id());
     }
     OpenSSLHashProvider hp;
-    HashBytes hash = hp.Hash(d.data(), d.size(), md_type);
+    HashBytes hash = hp.hash(d.data(), d.size(), md_type);
     return sign_hash(hash.data(), hash.size());
   }
 
@@ -179,7 +179,7 @@ namespace ccf::crypto
       md_type = get_md_for_ec(get_curve_id());
     }
     OpenSSLHashProvider hp;
-    HashBytes hash = hp.Hash(d.data(), d.size(), md_type);
+    HashBytes hash = hp.hash(d.data(), d.size(), md_type);
     return sign_hash(hash.data(), hash.size(), sig_size, sig);
   }
 

src/crypto/openssl/ec_public_key.cpp

@@ -184,7 +184,7 @@ namespace ccf::crypto
       md_type = get_md_for_ec(get_curve_id());
     }
     OpenSSLHashProvider hp;
-    bytes = hp.Hash(contents, contents_size, md_type);
+    bytes = hp.hash(contents, contents_size, md_type);
     return verify_hash(bytes.data(), bytes.size(), sig, sig_size, md_type);
   }
 

src/crypto/openssl/hash.h

@@ -53,7 +53,7 @@ namespace ccf::crypto
      * @param size The size of @p data
      * @param type The type of hash to compute
      */
-    HashBytes Hash(const uint8_t* data, size_t size, MDType type) const override
+    HashBytes hash(const uint8_t* data, size_t size, MDType type) const override
     {
       const auto* o_md_type = OpenSSL::get_md_type(type);
       HashBytes r(EVP_MD_size(o_md_type));

src/crypto/openssl/rsa_key_pair.cpp

@@ -219,7 +219,7 @@ namespace ccf::crypto
     constexpr size_t MAX_SIG_SIZE = 2048;
 
     std::vector<uint8_t> r(MAX_SIG_SIZE);
-    auto hash = OpenSSLHashProvider().Hash(d.data(), d.size(), md_type);
+    auto hash = OpenSSLHashProvider().hash(d.data(), d.size(), md_type);
     Unique_EVP_PKEY_CTX pctx(key);
     CHECK1(EVP_PKEY_sign_init(pctx));
     CHECK1(EVP_PKEY_CTX_set_rsa_padding(pctx, RSA_PKCS1_PSS_PADDING));