Remove dead code#7813
Merged
eddyashton merged 1 commit intomicrosoft:mainfrom Apr 10, 2026
Merged
Conversation
maxtropets
approved these changes
Apr 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused “removal” block in AFT Raft’s node-state maintenance logic, reducing dead code in the consensus implementation.
Changes:
- Delete an unused
to_removecollection and associated loop increate_and_remove_node_state().
Comments suppressed due to low confidence (1)
src/consensus/aft/raft.h:2813
create_and_remove_node_state()no longer contains any removal logic (the only removal-related block was dead). The name is now misleading; consider renaming it (and updating call sites) to reflect its actual behavior, or implement the intended removal of nodes not present in any active configuration to match the name.
// Add all active nodes that are not already present in the node state.
for (auto node_info : active_nodes)
{
if (node_info.first == state->node_id)
{
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.