Merged
Conversation
cjen1-msft
approved these changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the size of paginated historical range queries in the logging sample app, and tightens the Python ledger validator’s Merkle tree initialization by ensuring the “empty leaf” is immutable bytes.
Changes:
- Reduce historical query pagination size in
samples/apps/loggingfrom 10k seqnos/page to 5k seqnos/page. - Pass immutable
bytes(rather than a mutablebytearray) as the initial “empty leaf” to the PythonMerkleTree.
Custom instructions used:
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| samples/apps/logging/logging.cpp | Lowers max historical range page size to return smaller pages for large range queries. |
| python/src/ccf/ledger.py | Uses immutable bytes for the initial Merkle tree leaf to match MerkleTree.add_leaf(values: bytes) and avoid mutation hazards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.