Skip to content

Smaller historical range pages #7867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achamayou merged 2 commits into from
May 7, 2026
+2 −2
Merged

Smaller historical range pages #7867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a76b9c
Smaller historical range pages
achamayou May 7, 2026
f5346a5
tweak
achamayou May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/src/ccf/ledger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ def __init__(
# Don't hash empty bytes array.
self.merkle = MerkleTree()
empty_bytes_array = bytearray(SHA256_DIGEST_SIZE)
self.merkle.add_leaf(empty_bytes_array, do_hash=False)
self.merkle.add_leaf(bytes(empty_bytes_array), do_hash=False)

self.last_verified_seqno = 0
self.last_verified_view = 0
Expand Down
2 changes: 1 addition & 1 deletion samples/apps/logging/logging.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1813,7 +1813,7 @@ namespace loggingapp
}

// Set a maximum range, paginate larger requests
static constexpr size_t max_seqno_per_page = 10000;
static constexpr size_t max_seqno_per_page = 5000;
const auto range_begin = from_seqno;
const auto range_end =
std::min(to_seqno, range_begin + max_seqno_per_page);
Expand Down