Fix non-contiguous ledger after join from snapshot with copied in-progress chunk (#7871)#7872
Closed
Copilot wants to merge 6 commits into
Closed
Fix non-contiguous ledger after join from snapshot with copied in-progress chunk (#7871)#7872Copilot wants to merge 6 commits into
Copilot wants to merge 6 commits into
Conversation
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/08d9f13b-0ab6-41e3-b8d0-b46dc31f2fd9 Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/08d9f13b-0ab6-41e3-b8d0-b46dc31f2fd9 Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
achamayou
May 9, 2026 09:33
View session
Member
|
@copilot fix the code formatting and try again |
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/d609704c-2eb9-497d-a2fb-1324583fe76a Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Contributor
Author
maxtropets
reviewed
May 11, 2026
|
|
||
| ### Fixed | ||
|
|
||
| - When a joiner copied an in-progress (uncommitted) ledger chunk from its target and then resumed from a snapshot whose seqno covered the chunk's last entry, that chunk used to remain forever as a writable file on disk, leaving an apparent gap between the joiner's read-only `.committed` chunks and any new chunks it produced. `Ledger::init` now promotes such writable files to `.committed` so that the on-disk ledger remains contiguous up to the snapshot seqno (#7871, #7872). |
Contributor
Author
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/229d441f-e1ea-4c5e-b03b-fe0b5548f221 Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Contributor
|
@achamayou my recollection is that we require that every snapshot's seqno corresponds to the end of a ledger chunk. |
Member
|
@cjen1-msft I don't think it's in the middle of a chunk, but I think that the ledger files are copied when the last chunk before the snapshot is not yet closed. If the snapshot is also copied, this may be unlikely/impossible (but I am not sure that's the case, because the snapshot and ledger commit paths are somewhat independent), but if the snapshot is downloaded it's quite easy for that to happen obviously.
|
Member
|
Replaced by #7878 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #7871 (
reconfiguration.test_ledger_invariantsfailure: non-contiguous chunks after join from snapshot when target had an in-progress chunk).Ledger::init(idx, ...), promote any recovered writable file whose entries are entirely ≤idxto.committedbefore clearing the in-memory list, so the on-disk ledger is contiguous up to the snapshot seqno.src/host/test/ledger.cppreproducing the scenario (writable file present at init).[7.0.3]→Fixed(with PR number reference).ledger_test17/17 pass,files_cleanup_test38/38 pass).scripts/check-format.sh(clang-format-18) to changed C++ files.