Skip to content

Update 1ES pool tags and restrict to UseScaleSet=true#7949

Closed
Copilot wants to merge 3 commits into
mainfrom
copilot/add-usescaleset-to-pool-tags
Closed

Update 1ES pool tags and restrict to UseScaleSet=true#7949
Copilot wants to merge 3 commits into
mainfrom
copilot/add-usescaleset-to-pool-tags

Conversation

Copilot AI commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Migrates GitHub Actions workflows using 1ES pools to utilize scale set infrastructure. The pools are restricted to require "UseScaleSet=true" while removing extraneous labels such as JobId to comply with pool tagging rules.

Workflow Agent Pool Tag Updates

  • Added UseScaleSet=true: Added VMSS tag requirement across all 1ES pools to enable elastic scalability.
  • Removed JobId: Removed the JobId tag from all self-hosted runner pools to restrict execution to standard 1ES configuration labels.
  • YAML Formatting: Formatted runner configurations inline for consistent structure.

Configuration Example

# Before
runs-on:
  [
    self-hosted,
    1ES.Pool=gha-vmss-d16av5-ci,
    "JobId=ci_build_tidy-${{ github.run_id }}-${{ github.run_number }}-${{ github.run_attempt }}",
  ]

# After
runs-on: [self-hosted, 1ES.Pool=gha-vmss-d16av5-ci, "UseScaleSet=true"]

Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot AI changed the title Update 1ES pool tags and remove JobId labels in workflows Update 1ES pool tags and restrict to UseScaleSet=true Jun 17, 2026
Copilot AI requested a review from achamayou June 17, 2026 15:11
@eddyashton

Copy link
Copy Markdown
Member

The tag mentioned in the docs is a tag on the Azure Resources. I've applied that, and correct the label style in this PR, but still no dice.

@eddyashton

Copy link
Copy Markdown
Member

The tagging on the Azure resources appears insufficient (this PR is still stalled), and has potentially contributed to flakiness in all of our other CI runs. Hard to be sure, but I've removed the tags for now. Suggest we revisit this if and when it's a priority, and we have a clean baseline to test from.

@achamayou achamayou closed this Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants