Get Nagler building on Linux (#523)

* Get Nagler building on Linux

Includes all changes needed to make sure that Nagler builds on Linux.
Note: Nagler is not exercised on Linux yet, so there may be bugs.

1) Removes dependency on the PAL for Nagler
  1) Copies/modifies a number of headers from the dotnet PAL
  2) Reimplements a couple of standard Windows crt apis
  3) Adds platform independent environment variable reading
  4) Remove unneeded reference to atl in InitOnce
  5) Replace ATL asserts with custom assert code.
2) Update Nagler to run on Linux
  1) Fix string to use "tstring"  and _T( instead of L"
  2) Update XML loading to only multithread on Windows
     (since Windows uses COM for xml reading)
  3) Disable "Inject Assembly" tests on Linux.
3) Add Nagler to the Linux CMake
  1) Update CMake to allow libraries to declare
     when they link to the PAL
  2) Add Nagler to the root cmake.
4) Fix some of the local build scripts

* Fix getenv

* Fix CMake add_exe

* Remove redundancies.

We have a dependency on Macros.h anyway, so
make use of it in Nagler.

* clean up dllmain

* Code review comments.

* Add namespace to reference to SystemString

Author: Del Myers

src/CMakeLists.txt

@@ -94,8 +94,6 @@ macro (build_init build_language build_type)
     include_directories(${REPOSITORY_ROOT}/src/unix/inc/empty)
     include_directories(${REPOSITORY_ROOT}/src/unix/inc/winsdk)
     include_directories(${REPOSITORY_ROOT}/src/InstrumentationEngine.Api)
-    include_directories(${CORECLR_PAL_ROOT}/inc)
-    include_directories(${CORECLR_PAL_ROOT}/inc/rt)
     include_directories(${GENERATED_INCLUDE_DIR})
     include_directories(${REPOSITORY_ROOT}/inc/clr/extra)
 
@@ -167,14 +165,18 @@ endmacro (build_init)
 
 
 # projects that depend on the PAL.
-macro(add_lib lib_name type use_redefines hide_symbols)
+macro(add_lib lib_name type use_pal use_redefines hide_symbols)
     add_library(${lib_name}
         ${type}
         ${ARGN})
 
-    if (${use_redefines})
-        add_dependencies(${lib_name} pal_redefines_header)
-    endif (${use_redefines})
+    if (${use_pal})
+        target_include_directories(${lib_name} PUBLIC ${CORECLR_PAL_ROOT}/inc)
+        target_include_directories(${lib_name} PUBLIC ${CORECLR_PAL_ROOT}/inc/rt)
+        if (${use_redefines})
+            add_dependencies(${lib_name} pal_redefines_header)
+        endif (${use_redefines})
+    endif (${use_pal})
 
     if (${hide_symbols})
         set_property(TARGET ${lib_name} APPEND_STRING PROPERTY COMPILE_FLAGS "-fvisibility=hidden")
@@ -183,13 +185,17 @@ endmacro(add_lib lib_name type use_redefines hide_symbols sources)
 
 # Adds an executable and optionally adds dependency on generated file pal_redefines.h for
 # projects that depend on the PAL.
-macro(add_exe exe_name use_redefines)
+macro(add_exe exe_name use_pal use_redefines)
     add_executable(${exe_name}
         ${ARGN})
 
-    if (${use_redefines})
-        add_dependencies(${exe_name} pal_redefines_header)
-    endif (${use_redefines})
+    if (${use_pal})
+        target_include_directories(${exe_name} PUBLIC ${CORECLR_PAL_ROOT}/inc)
+        target_include_directories(${exe_name} PUBLIC ${CORECLR_PAL_ROOT}/inc/rt)
+        if (${use_redefines})
+            add_dependencies(${exe_name} pal_redefines_header)
+        endif (${use_redefines})
+    endif (${use_pal})
 endmacro(add_exe exe_name use_redefines sources)
 
 # Adds install target
@@ -365,6 +371,7 @@ add_subdirectory(Common.Lib)
 add_subdirectory(InstrumentationEngine.Api)
 add_subdirectory(InstrumentationEngine.Lib)
 add_subdirectory(InstrumentationEngine)
+add_subdirectory(Tests/InstrEngineTests/NaglerInstrumentationMethod)
 
 enable_testing()
 add_subdirectory(Tests/CommonLibTests)

src/Common.Headers/Common.Headers.vcxitems

@@ -16,6 +16,7 @@
     <ProjectCapability Include="SourceItemsFromImports" />
   </ItemGroup>
   <ItemGroup>
+    <ClInclude Include="$(MSBuildThisFileDirectory)Macros.h" />
     <ClInclude Include="$(MSBuildThisFileDirectory)banned.h" />
     <ClInclude Include="$(MSBuildThisFileDirectory)CriticalSectionHolder.h" />
     <ClInclude Include="$(MSBuildThisFileDirectory)InitOnce.h" />

src/Common.Headers/InitOnce.h

@@ -8,7 +8,6 @@
 #pragma warning(disable: 6285) // bug in <functional> that compares 0 to 0, resulting in a warning.
 #include <atomic>
 #include <functional>
-#include <atlsync.h>
 #pragma warning(pop)
 
 #include <thread>

src/Common.Lib/Macros.h src/Common.Headers/Macros.hsrc/Common.Lib/Macros.h renamed to src/Common.Headers/Macros.h

@@ -22,6 +22,7 @@ set(src_files
 
 add_lib(${PROJECT_NAME}
     STATIC
+    false # use_pal
     false # use_redefines
     true # hide_symbols
     ${src_files}

src/Common.Lib/CMakeLists.txt

@@ -36,7 +36,7 @@
 #include <msxml6.h>
 #endif
 
-#include "Macros.h"
+#include "../Common.Headers/Macros.h"
 #include "refcount.h"
 
 #include "../Common.Headers/banned.h"

src/Common.Lib/stdafx.h

@@ -14,6 +14,7 @@ set(src_files ./InstrumentationEngine_api.cpp)
 
 add_lib(InstrumentationEngine.Api
     STATIC
+    true # use_pal
     false # use_redefines
     false # hide_symbols
     ${src_files}

src/InstrumentationEngine.Api/CMakeLists.txt

@@ -26,6 +26,7 @@ set(src_files
 
 add_lib(${PROJECT_NAME}
     STATIC
+    true # use_pal
     true # use_redefines
     false # hide_symbols
     ${src_files}

src/InstrumentationEngine.Lib/CMakeLists.txt

@@ -112,7 +112,7 @@ using namespace ATL;
 #include "SharedArray.h"
 
 #include "../Common.Headers/tstring.h"
-#include "../Common.Lib/Macros.h"
+#include "../Common.Headers/Macros.h"
 #include "../Common.Headers/CriticalSectionHolder.h"
 #include "../Common.Headers/InitOnce.h"
 #include "../Common.Headers/Singleton.h"

src/InstrumentationEngine.Lib/stdafx.h

@@ -5,7 +5,6 @@
 
 #include "stdafx.h"
 #include "../Common.Lib/EventLoggingBase.h"
-#include "../Common.Headers/InitOnce.h"
 
 using namespace CommonLib;