Skip to content

Commit 045d6d8

Browse files
committed
Corrections to group check in MDOThreatPolicyChecker.ps1
Incorrect lookup in groups as only one group was being checked instead of all groups. Also retrieved all members of group.
1 parent a180a03 commit 045d6d8

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

M365/MDO/MDOThreatPolicyChecker.ps1

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ begin {
191191
$groupMembers = $null
192192
Write-Verbose "Getting $GroupObjectId"
193193
try {
194-
$groupMembers = Get-MgGroupMember -GroupId $GroupObjectId -ErrorAction Stop
194+
$groupMembers = Get-MgGroupMember -GroupId $GroupObjectId -All -ErrorAction Stop
195195
} catch {
196196
Write-Host "Error getting group members for $GroupObjectId`:`n$_" -ForegroundColor Red
197197
return $null
@@ -351,7 +351,6 @@ begin {
351351
break
352352
} else {
353353
Write-DetailedExplanationOption -Message "No Group match because $($Email.ToString()) is not a member of Group $($groupObjectId)" -ShowDetailedExplanation:$ShowDetailedExplanation
354-
break
355354
}
356355
}
357356
}
@@ -370,7 +369,6 @@ begin {
370369
break
371370
} else {
372371
Write-DetailedExplanationOption -Message "$($Email.ToString()) is not excluded from rule by membership in Group $($groupObjectId)" -ShowDetailedExplanation:$ShowDetailedExplanation
373-
break
374372
}
375373
}
376374
}

0 commit comments

Comments
 (0)