Skip to content

Commit 0ad41f1

Browse files
code quality issue
1 parent dcd6040 commit 0ad41f1

4 files changed

Lines changed: 4 additions & 5 deletions

File tree

src/backend-api/src/tests/base/test_sk_logic_base.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import importlib
1111
import sys
1212
import types
13-
from typing import Type
1413
from unittest.mock import MagicMock
1514

1615
import pytest

src/frontend/src/components/batchHistoryPanel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React, { useState, useEffect, useRef } from "react";
22

3-
import { useDispatch, useSelector } from 'react-redux';
3+
import { useDispatch } from 'react-redux';
44
import { Card, Spinner, Tooltip } from "@fluentui/react-components";
55
import { useNavigate } from "react-router-dom";
66
import ConfirmationDialog from "../commonComponents/ConfirmationDialog/confirmationDialogue";

src/processor/src/tests/unit/libs/application/test_application_context_extras.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ async def _run():
118118

119119
def test_create_async_instance_with_callable_factory():
120120
async def _run():
121-
ctx = AppContext().add_async_singleton(_AsyncSvc, lambda: _AsyncSvc())
121+
ctx = AppContext().add_async_singleton(_AsyncSvc, _AsyncSvc)
122122
a = await ctx.get_service_async(_AsyncSvc)
123123
assert isinstance(a, _AsyncSvc)
124124
assert a.entered is True
@@ -151,7 +151,7 @@ async def _run():
151151

152152

153153
def test_create_instance_with_factory_callable():
154-
ctx = AppContext().add_singleton(_S, lambda: _S())
154+
ctx = AppContext().add_singleton(_S, _S)
155155
a = ctx.get_service(_S)
156156
assert isinstance(a, _S)
157157

src/processor/src/tests/unit/services/test_queue_service_internals.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ async def _go():
189189
try:
190190
await task
191191
except (asyncio.CancelledError, Exception):
192-
pass
192+
pass # Expected during task cancellation cleanup
193193

194194
_run(_go())
195195

0 commit comments

Comments
 (0)