Skip to content

Commit 36cd758

Browse files
author
Shreyas-Microsoft
committed
provide allowed locations and test workflow
1 parent 55b5c89 commit 36cd758

2 files changed

Lines changed: 22 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ on:
55
- main
66
- dev
77
- demo
8+
pull_request:
9+
branches:
10+
- dev
811
schedule:
912
- cron: '0 9,21 * * *' # Runs at 9:00 AM and 9:00 PM GMT
1013
workflow_dispatch: # Allow manual triggering
@@ -110,9 +113,7 @@ jobs:
110113
az deployment group create \
111114
--resource-group ${{ env.RESOURCE_GROUP_NAME }} \
112115
--template-file infra/main.bicep \
113-
--parameters solutionName=${{env.SOLUTION_PREFIX}} \
114-
--parameters location=${{ env.AZURE_LOCATION }} \
115-
--parameters aiDeploymentLocation=${{ env.AZURE_LOCATION }}
116+
--parameters solutionName=${{env.SOLUTION_PREFIX}}
116117
117118
118119
- name: Extract AI Services and Key Vault Names

infra/main.bicep

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ param solutionUniqueText string = substring(uniqueString(subscription().id, reso
1111

1212
@minLength(3)
1313
@metadata({ azd: { type: 'location' } })
14-
@description('Optional. Azure region for all services. Defaults to the resource group location.')
14+
@description('Required. Azure region for container apps, storage, and other services. Choose a region close to your users.')
1515
param location string
1616
var solutionLocation = empty(location) ? resourceGroup().location : location
1717

@@ -36,7 +36,23 @@ var solutionLocation = empty(location) ? resourceGroup().location : location
3636
]
3737
}
3838
})
39-
@description('Optional. Location for all AI service resources. This location can be different from the resource group location.')
39+
@description('Required. Azure region for AI services (OpenAI/AI Foundry). Must be a region that supports o3 model deployment.')
40+
param azureAiServiceLocation string
41+
42+
@allowed([
43+
'australiaeast'
44+
'eastus'
45+
'eastus2'
46+
'francecentral'
47+
'japaneast'
48+
'norwayeast'
49+
'southindia'
50+
'swedencentral'
51+
'uksouth'
52+
'westus'
53+
'westus3'
54+
])
55+
@description('Required. Azure region for AI model deployment. Should match azureAiServiceLocation for optimal performance.')
4056
param aiDeploymentLocation string
4157

4258
@description('Optional. The host (excluding https://) of an existing container registry. This is the `loginServer` when using Azure Container Registry.')

0 commit comments

Comments
 (0)