Skip to content

Commit 6b3dce7

Browse files
Merge pull request #234 from microsoft/psl-fixcopilotcomments-cm
fix: fixed all copilot comments
2 parents 2ac4a94 + 094f7ac commit 6b3dce7

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/backend-api/src/app/libs/base/SKLogicBase.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from abc import ABC, abstractmethod
2-
from typing import Type, TypeVar, overload
2+
from typing import Any, Type, TypeVar, overload
33

44
from pydantic import BaseModel, Field
55
from semantic_kernel.agents import (
@@ -81,7 +81,7 @@ def _init_agent(self):
8181
"""
8282
raise NotImplementedError("This method should be overridden in subclasses")
8383

84-
async def execute(self, func_params: dict[str, any]):
84+
async def execute(self, func_params: dict[str, Any]):
8585
raise NotImplementedError("Execute method not implemented")
8686

8787
@overload

src/frontend/src/pages/modernizationPage.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1000,7 +1000,9 @@ useEffect(() => {
10001000
);
10011001
}
10021002
// Otherwise, show the progress view with summary information
1003-
const fileIndex = files.findIndex(file => file.fileId === fileId);
1003+
// selectedFileId/fileId is the internal UI id (e.g. "summary"/"file0"),
1004+
// so match against file.id rather than the server-side file.fileId.
1005+
const fileIndex = files.findIndex(file => file.id === fileId);
10041006
const currentFile = files[fileIndex];
10051007
return (
10061008
<>

src/processor/src/services/queue_service.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,8 +1119,6 @@ async def _process_queue_message(self, worker_id: int, queue_message: QueueMessa
11191119
execution_time,
11201120
task_param=task_param,
11211121
)
1122-
finally:
1123-
migration_processor = None # noqa: F841 — release reference for GC
11241122

11251123
except asyncio.CancelledError:
11261124
# When cancelled, we assume stop_process has already deleted the message

0 commit comments

Comments
 (0)