fix: fixed CodQL issue for Cotainer Migration.

Author: VishalS-Microsoft

scripts/validate_bicep_params.py

@@ -110,7 +110,7 @@ def parse_parameters_env_vars(json_path: Path) -> dict[str, list[str]]:
         data = json.loads(sanitized)
         params = data.get("parameters", {})
     except json.JSONDecodeError:
-        pass
+        pass  # Fall through with empty params if JSON is malformed
 
     # Walk each top-level parameter and scan its entire serialized value
     # for ${VAR} references from the original text.

src/backend-api/src/app/application.py

@@ -133,7 +133,7 @@ def _register_dependencies(self):
             )
             .add_singleton(ILoggerService, ConsoleLoggerService)
             .add_transient(IHttpService, HttpClientService)
-            .add_singleton(IDataService, lambda: InMemoryDataService())
+            .add_singleton(IDataService, InMemoryDataService)
         )
 
     def run(self, host: str = "0.0.0.0", port: int = 8000, reload: bool = True):

src/backend-api/src/app/libs/base/SKLogicBase.py

@@ -81,7 +81,7 @@ def _init_agent(self):
         """
         raise NotImplementedError("This method should be overridden in subclasses")
 
-    async def execute(func_params: dict[str, any]):
+    async def execute(self, func_params: dict[str, any]):
         raise NotImplementedError("Execute method not implemented")
 
     @overload
@@ -92,7 +92,7 @@ async def execute_thread(
         thread: AgentThread | AssistantAgentThread | AzureAIAgentThread = None,
     ) -> tuple[str, AgentThread | AssistantAgentThread | AzureAIAgentThread]:
         """When response_format is None, returns string response."""
-        ...
+        pass
 
     @overload
     async def execute_thread(
@@ -102,7 +102,7 @@ async def execute_thread(
         thread: AgentThread | AssistantAgentThread | AzureAIAgentThread = None,
     ) -> tuple[T, AgentThread | AssistantAgentThread | AzureAIAgentThread]:
         """When response_format is provided, returns typed Pydantic BaseModel response."""
-        ...
+        pass
 
     @abstractmethod
     async def execute_thread(

src/backend-api/src/app/libs/base/fastapi_protocol.py

@@ -17,7 +17,7 @@ class FastAPIWithContext(Protocol):
 
     # Include essential FastAPI methods for type checking
     def include_router(self, *args, **kwargs) -> None:
-        ...
+        pass
 
 
 def add_app_context_to_fastapi(

src/backend-api/src/app/libs/repositories/process_status_repository.py

@@ -320,11 +320,7 @@ async def render_agent_status(self, process_id: str) -> dict:
                     )
                     process_duration_seconds = int((end - start).total_seconds())
                 except Exception:
-                    pass
-
-            early_failure = (
-                process_failed and process_duration_seconds < 30
-            )  # Failed in less than 30 seconds
+                    pass  # Duration calculation is best-effort; default to 0 on parse failure
 
             # Analyze each agent with enhanced insights
             for agent_name, agent_data in agents_data.items():

src/backend-api/src/app/libs/services/interfaces.py

@@ -2,7 +2,7 @@
 # Licensed under the MIT License.
 
 from abc import ABC, abstractmethod
-from typing import Any, Dict, Union
+from typing import Any, Dict
 
 
 class IDataService(ABC):

src/backend-api/src/app/routers/models/files.py

@@ -1,4 +1,3 @@
-from datetime import datetime, timezone
 from pydantic import BaseModel, Field
 
 

src/backend-api/src/app/routers/router_files.py

@@ -13,17 +13,14 @@
 )
 from fastapi.responses import Response
 from libs.base.typed_fastapi import TypedFastAPI
-from libs.models.entities import File, Process
+from libs.models.entities import File
 from libs.sas.storage import AsyncStorageBlobHelper
 from libs.services.auth import get_authenticated_user
 from libs.services.input_validation import is_valid_uuid
 from libs.services.interfaces import ILoggerService
-from libs.sas.storage import AsyncStorageBlobHelper
-from libs.models.entities import File, Process
 from routers.models.files import FileUploadResult
 from libs.repositories.process_repository import ProcessRepository
 from libs.repositories.file_repository import FileRepository
-from libs.repositories.process_repository import ProcessRepository
 
 router = APIRouter(
     prefix="/api/file",

src/backend-api/src/tests/application/test_dependency_injection.py

@@ -126,7 +126,7 @@ def test_factory_registration():
     app_context = AppContext()
 
     # Register with factory function
-    app_context.add_singleton(IDataService, lambda: InMemoryDataService())
+    app_context.add_singleton(IDataService, InMemoryDataService)
 
     data_service = app_context.get_service(IDataService)
     assert isinstance(data_service, InMemoryDataService)

src/frontend/frontend_server.py

@@ -4,7 +4,7 @@
 from dotenv import load_dotenv
 from fastapi import FastAPI, Request
 from fastapi.middleware.cors import CORSMiddleware
-from fastapi.responses import FileResponse, HTMLResponse, JSONResponse
+from fastapi.responses import FileResponse, JSONResponse
 from fastapi.staticfiles import StaticFiles
 
 # Load environment variables from .env file
@@ -42,7 +42,6 @@ async def serve_index():
 async def get_config(request: Request):
     # Only serve config to same-origin requests by checking the Referer/Origin
     origin = request.headers.get("origin") or ""
-    referer = request.headers.get("referer") or ""
     host = request.headers.get("host") or ""
     if origin and not origin.endswith(host):
         return JSONResponse(status_code=403, content={"detail": "Forbidden"})